feat(compiler): scope selectors in @starting-style#53943
feat(compiler): scope selectors in @starting-style#53943puckowski wants to merge 1 commit intoangular:mainfrom
Conversation
There was a problem hiding this comment.
| it('should scope normal selectors inside a startling-style rule', () => { | |
| it('should scope normal selectors inside a starting-style rule', () => { |
There was a problem hiding this comment.
Maybe the starting style is startling!
There was a problem hiding this comment.
Thank you for catching the typo. Should be resolved now. @eneajaho
make sure selectors inside @starting-style queries are correctly scoped
2360a89 to
b4d42c1
Compare
|
Angular 17 Stackblitz where Angular 17 custom build which includes this PR where |
|
This PR was merged into the repository by commit 66e940a. |
|
Thank you for merging. Looking forward to using this feature in my Angular apps. |
|
@puckowski thanks for creating this PR and helping to improve Angular! 👍 |
make sure selectors inside @starting-style queries are correctly scoped PR Close angular#53943
make sure selectors inside @starting-style queries are correctly scoped PR Close angular#53943
make sure selectors inside @starting-style queries are correctly scoped PR Close angular#53943
make sure selectors inside @starting-style queries are correctly scoped PR Close angular#53943
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This pull request makes sure selectors inside
@starting-stylequeries are correctly scoped.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
Currently
@starting-stylequeries defined for components are not correctly scoped. This may cause style leakage.What is the new behavior?
With this PR,
@starting-stylequeries would be correctly scoped. This would prevent style leakage.Does this PR introduce a breaking change?
The
@starting-styleat-rule was introduced in Chrome 117 (https://chromestatus.com/feature/4515377717968896). Early adopters will see styles within their application applied differently with this change. This will require a small developer effort to address.Firefox and Safari do not currently support
@starting-style(https://caniuse.com/mdn-css_at-rules_starting-style).Firefox's position is positive (mozilla/standards-positions#833).
I could not find Safari's position on introducing
@starting-style.WebKit hasn't officially stated a position on
@starting-style(WebKit/standards-positions#210).Other information
I think by adopting this PR before
@starting-styleis widely adopted we can avoid some developer frustration.