fix(common): remove unused parameters from the ngClass constructor#53831
fix(common): remove unused parameters from the ngClass constructor#53831josephperrott wants to merge 1 commit intoangular:mainfrom
Conversation
Remove unused parameters which were only being kept because of a downstream usage in flex layout which is deprecated and end of life
|
Removing breaking change label and targeting for patch. We don't consider constructors of injectables part of the public API and do not allow extending classes unless explicitly noted in the documentation: https://github.com/angular/angular/blob/main/docs/PUBLIC_API.md#supported-public-api-surface-of-angular |
atscott
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
|
This PR was merged into the repository by commit 1be6b0a. |
|
What is the best solution for those who haven't yet completed migration from Angular Flex Layout? Is there any reliable Angular Flex Layout fork, which is maintained by the community? |
|
It's also awkward because updating to latest patch version broke our build, lol. Yes, we use Angular 17, Angular Material 16, and Angular Flex Layout 15. Not even sure what to say at this point, it's not like migrating custom Angular Material based components is a walk in the park and the new Angular 17 features are nice. Getting rid of Angular Material entirely isn't also a walk in the park at this point, so here we are, great. |
|
@alfaproject I think I have a relatively easy solution to the Flex Layout problem. I haven't yet implemented it, but I'm pretty sure it should work. |
|
Yeah, thank you for the tips. We did a patch instead until we have enough bandwidth to get rid of flex layout or reimplement/copy what we need. |
|
@josephperrott @atscott @skovalyov @alfaproject @pkozlowski-opensource I fully understand that you want to remove any code from the Angular source that references a Library that's gone EOL, but I would like to try and maintain the library for as long as possible (I know this is in decline) but there are still a lot of projects using it. I would like to try and understand what these two parameters were used for, in the hope that I can find another solution that doesn't require these parameters. |
In angular/angular#53831 `NgClass` directive constructor signature was updated, which is a breaking change for Angular Flex Layout. This change updates the signature by removing `iterableDiffers` and `keyValueDiffers`, which are not used anymore.
In angular/angular#53831 `NgClass` directive constructor signature was updated, which is a breaking change for Angular Flex Layout. This change updates the signature by removing `iterableDiffers` and `keyValueDiffers`, which are not used anymore.
* Merge 17 branch into main (#46) * feat(project): upgrade to Angular 17 * fix(update): issues with linting - still using tslint needs upgrading to eslint * fix(update): fix yarn install to latest node * fix(update): fix local test browser node version * chore(changelog): update changelog * Update README.md (#47) * fix(update): update orbs in CI * Update Angular version and fix NgClass directive (#50) In angular/angular#53831 `NgClass` directive constructor signature was updated, which is a breaking change for Angular Flex Layout. This change updates the signature by removing `iterableDiffers` and `keyValueDiffers`, which are not used anymore. * fix(package): update package json to match yarn lock for browser-sync-client * fix(package): remove package lock file * fix(etag): removed etag * fix(yarn): removed mitt.1.2 * fix(yarn): lock issues failing CI * fix(typescript): version of typescript was too high * chore:(build): create release 17.0.1 --------- Co-authored-by: Sergey Kovalyov <skovalyov@gmail.com>
…ngular#53831) Remove unused parameters which were only being kept because of a downstream usage in flex layout which is deprecated and end of life PR Close angular#53831
…ngular#53831) Remove unused parameters which were only being kept because of a downstream usage in flex layout which is deprecated and end of life PR Close angular#53831
…ngular#53831) Remove unused parameters which were only being kept because of a downstream usage in flex layout which is deprecated and end of life PR Close angular#53831
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Remove unused parameters which were only being kept because of a downstream usage in flex layout which is deprecated and end of life.