Skip to content

fix(platform-server): Do not delete global Event#53659

Closed
atscott wants to merge 2 commits intoangular:mainfrom
atscott:dominoEvent
Closed

fix(platform-server): Do not delete global Event#53659
atscott wants to merge 2 commits intoangular:mainfrom
atscott:dominoEvent

Conversation

@atscott
Copy link
Copy Markdown
Contributor

@atscott atscott commented Dec 20, 2023 •
edited
Loading

This commit removes a hack that deletes Event from the global context when using domino. Instead, it sets the global event to domino's implementation of Event.

The "Trick to avoid Event patching" links to a state in the repository that is 6(!) years old:

angular/packages/platform-browser/src/dom/events/dom_events.ts

Lines 112 to 132 in 7cf5e95

private patchEvent() {
if (!Event || !Event.prototype) {
return;
}
if ((Event.prototype as any)[stopMethodSymbol]) {
// already patched by zone.js
return;
}
const delegate = (Event.prototype as any)[stopMethodSymbol] =
Event.prototype.stopImmediatePropagation;
Event.prototype.stopImmediatePropagation = function() {
if (this) {
this[stopSymbol] = true;
}
// should call native delegate in case
// in some enviroment part of the application
// will not use the patched Event
delegate && delegate.apply(this, arguments);
};
}
. A lot has changed since then. I don't know what the implications might be with this change but @tbondwilkinson and I are encountering issues with events when working with the navigation API that are caused by this bit of hackery.

@atscott
fix(platform-server): Do not delete global Event
beb0374 
This commit removes a hack that deletes `Event` from the global context
when using domino. Instead, it sets the global event to domino's
implementation of `Event`.
@atscott atscott marked this pull request as ready for review January 4, 2024 18:07
@atscott atscott requested a review from AndrewKushnir January 4, 2024 18:07
@pullapprove pullapprove bot requested a review from devversion January 4, 2024 18:08
AndrewKushnir
AndrewKushnir reviewed Jan 4, 2024
View reviewed changes
@atscott atscott added area: testing Issues related to Angular testing features, such as TestBed target: patch This PR is targeted for the next patch release labels Jan 4, 2024
@ngbot ngbot bot modified the milestone: Backlog Jan 4, 2024
@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Jan 4, 2024
@atscott
Copy link
Copy Markdown
Contributor Author

atscott commented Jan 4, 2024

This PR was merged into the repository by commit f4bd5a3.

@atscott atscott closed this in f4bd5a3 Jan 4, 2024
atscott added a commit that referenced this pull request Jan 4, 2024
@atscott
fix(platform-server): Do not delete global Event (#53659)
91cb16f 
This commit removes a hack that deletes `Event` from the global context
when using domino. Instead, it sets the global event to domino's
implementation of `Event`.

PR Close #53659
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
@atscott @ChellappanRajan
fix(platform-server): Do not delete global Event (angular#53659)
668f2ec 
This commit removes a hack that deletes `Event` from the global context
when using domino. Instead, it sets the global event to domino's
implementation of `Event`.

PR Close angular#53659
rlmestre pushed a commit to rlmestre/angular that referenced this pull request Jan 26, 2024
@atscott @rlmestre
fix(platform-server): Do not delete global Event (angular#53659)
5f68d77 
This commit removes a hack that deletes `Event` from the global context
when using domino. Instead, it sets the global event to domino's
implementation of `Event`.

PR Close angular#53659
amilamen pushed a commit to amilamen/angular that referenced this pull request Jan 26, 2024
@atscott @amilamen
fix(platform-server): Do not delete global Event (angular#53659)
69e342b 
This commit removes a hack that deletes `Event` from the global context
when using domino. Instead, it sets the global event to domino's
implementation of `Event`.

PR Close angular#53659
@mateusbeckup mateusbeckup mentioned this pull request Feb 2, 2024
Open
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Feb 4, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: testing Issues related to Angular testing features, such as TestBed target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@atscott @devversion @AndrewKushnir