Project the root node of empty blocks#53620
Closed
crisbeto wants to merge 2 commits intoangular:mainfrom
Closed
Conversation
Expands the workaround from angular#52414 to allow for the root nodes of `@empty` blocks to be content projected. Fixes angular#53570.
crisbeto
commented
Dec 18, 2023
pkozlowski-opensource
approved these changes
Dec 18, 2023
Member
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
LGTM - this was fast!
dylhunn
approved these changes
Dec 19, 2023
Contributor
dylhunn
left a comment
There was a problem hiding this comment.
You mentioned you were worried the template pipeline part was messy, but IMO it's not that messy! Just the one thing you already pointed out, which is a known refactoring task :)
Updates the template pipeline to allow for the root node of an `@empty` block to be content projected.
9ea6f3d to
78a855e
Compare
Contributor
|
This PR was merged into the repository by commit 478d622. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
Expands the workaround from angular#52414 to allow for the root nodes of `@empty` blocks to be content projected. Fixes angular#53570. PR Close angular#53620
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…gular#53620) Updates the template pipeline to allow for the root node of an `@empty` block to be content projected. PR Close angular#53620
rlmestre
pushed a commit
to rlmestre/angular
that referenced
this pull request
Jan 26, 2024
Expands the workaround from angular#52414 to allow for the root nodes of `@empty` blocks to be content projected. Fixes angular#53570. PR Close angular#53620
rlmestre
pushed a commit
to rlmestre/angular
that referenced
this pull request
Jan 26, 2024
…gular#53620) Updates the template pipeline to allow for the root node of an `@empty` block to be content projected. PR Close angular#53620
amilamen
pushed a commit
to amilamen/angular
that referenced
this pull request
Jan 26, 2024
Expands the workaround from angular#52414 to allow for the root nodes of `@empty` blocks to be content projected. Fixes angular#53570. PR Close angular#53620
amilamen
pushed a commit
to amilamen/angular
that referenced
this pull request
Jan 26, 2024
…gular#53620) Updates the template pipeline to allow for the root node of an `@empty` block to be content projected. PR Close angular#53620
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes a couple of commits that allow for the root node of an
@emptyblock to be content projected.fix(compiler): project empty block root node
Expands the workaround from #52414 to allow for the root nodes of
@emptyblocks to be content projected.fix(compiler): project empty block root node in template pipeline
Updates the template pipeline to allow for the root node of an
@emptyblock to be content projected.Fixes #53570.