fix(migrations): ensure we do not overwrite prior template replacements in migration#53393
Closed
jessicajaniuk wants to merge 1 commit intoangular:mainfrom
Closed
fix(migrations): ensure we do not overwrite prior template replacements in migration#53393jessicajaniuk wants to merge 1 commit intoangular:mainfrom
jessicajaniuk wants to merge 1 commit intoangular:mainfrom
Conversation
crisbeto
approved these changes
Dec 6, 2023
Contributor
Author
|
Caretaker Note: G3 failures are unrelated. Safe to merge. |
4849a3b to
0414e0b
Compare
…ts in migration This fixes a bug where only the last replacement of a template placeholder would apply. fixes: angular#53383
0414e0b to
0fa983f
Compare
Member
|
This PR was merged into the repository by commit 1f5c8bf. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…ts in migration (angular#53393) This fixes a bug where only the last replacement of a template placeholder would apply. fixes: angular#53383 PR Close angular#53393
rlmestre
pushed a commit
to rlmestre/angular
that referenced
this pull request
Jan 26, 2024
…ts in migration (angular#53393) This fixes a bug where only the last replacement of a template placeholder would apply. fixes: angular#53383 PR Close angular#53393
amilamen
pushed a commit
to amilamen/angular
that referenced
this pull request
Jan 26, 2024
…ts in migration (angular#53393) This fixes a bug where only the last replacement of a template placeholder would apply. fixes: angular#53383 PR Close angular#53393
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where only the last replacement of a template placeholder would apply.
fixes: #53383
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?