Skip to content

fix(migrations): Update CF migration to skip templates with duplicate ng-template names#53204

Closed
jessicajaniuk wants to merge 1 commit intoangular:mainfrom
jessicajaniuk:duplicate-templates
Closed

fix(migrations): Update CF migration to skip templates with duplicate ng-template names#53204
jessicajaniuk wants to merge 1 commit intoangular:mainfrom
jessicajaniuk:duplicate-templates

Conversation

@jessicajaniuk
Copy link
Copy Markdown
Contributor

This adds a message to the console and skips any templates that detect duplicate ng-template names in the same component.
fixes: #53169

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • Yes
  • No

@jessicajaniuk jessicajaniuk added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release area: migrations Issues related to `ng update`/`ng generate` migrations labels Nov 27, 2023
@ngbot ngbot bot added this to the Backlog milestone Nov 27, 2023
@jessicajaniuk jessicajaniuk force-pushed the duplicate-templates branch 2 times, most recently from a8bddef to ba24418 Compare November 27, 2023 17:30
… ng-template names

This adds a message to the console and skips any templates that detect duplicate ng-template names in the same component.
fixes: angular#53169
@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 28, 2023
@pkozlowski-opensource
Copy link
Copy Markdown
Member

This PR was merged into the repository by commit 8a52674.

pkozlowski-opensource pushed a commit that referenced this pull request Nov 28, 2023
… ng-template names (#53204)

This adds a message to the console and skips any templates that detect duplicate ng-template names in the same component.
fixes: #53169

PR Close #53204
@jessicajaniuk jessicajaniuk deleted the duplicate-templates branch November 28, 2023 17:09
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 29, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
… ng-template names (angular#53204)

This adds a message to the console and skips any templates that detect duplicate ng-template names in the same component.
fixes: angular#53169

PR Close angular#53204
rlmestre pushed a commit to rlmestre/angular that referenced this pull request Jan 26, 2024
… ng-template names (angular#53204)

This adds a message to the console and skips any templates that detect duplicate ng-template names in the same component.
fixes: angular#53169

PR Close angular#53204
amilamen pushed a commit to amilamen/angular that referenced this pull request Jan 26, 2024
… ng-template names (angular#53204)

This adds a message to the console and skips any templates that detect duplicate ng-template names in the same component.
fixes: angular#53169

PR Close angular#53204
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update`/`ng generate` migrations target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: 🐛 @angular/core-control-flow schematic issues

4 participants