Skip to content

fix(migrations): fixes migrations of nested switches in control flow#53010

Closed
jessicajaniuk wants to merge 1 commit intoangular:mainfrom
jessicajaniuk:migration-nestedswitch
Closed

fix(migrations): fixes migrations of nested switches in control flow#53010
jessicajaniuk wants to merge 1 commit intoangular:mainfrom
jessicajaniuk:migration-nestedswitch

Conversation

@jessicajaniuk
Copy link
Copy Markdown
Contributor

This separates out the NgSwitch migration pass from the NgSwitchCase / Default pass, which makes nested switch migrations work.

fixes: #53009

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • Yes
  • No

@jessicajaniuk jessicajaniuk added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release area: migrations Issues related to `ng update`/`ng generate` migrations labels Nov 17, 2023
@ngbot ngbot bot added this to the Backlog milestone Nov 17, 2023
This separates out the NgSwitch migration pass from the NgSwitchCase / Default pass, which makes nested switch migrations work.

fixes: angular#53009
@AndrewKushnir AndrewKushnir removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Nov 17, 2023
@jessicajaniuk jessicajaniuk added the action: merge The PR is ready for merge by the caretaker label Nov 17, 2023
@AndrewKushnir
Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit 28f6cbf.

AndrewKushnir pushed a commit that referenced this pull request Nov 20, 2023
…53010)

This separates out the NgSwitch migration pass from the NgSwitchCase / Default pass, which makes nested switch migrations work.

fixes: #53009

PR Close #53010
@jessicajaniuk jessicajaniuk deleted the migration-nestedswitch branch November 28, 2023 17:09
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 29, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
…ngular#53010)

This separates out the NgSwitch migration pass from the NgSwitchCase / Default pass, which makes nested switch migrations work.

fixes: angular#53009

PR Close angular#53010
rlmestre pushed a commit to rlmestre/angular that referenced this pull request Jan 26, 2024
…ngular#53010)

This separates out the NgSwitch migration pass from the NgSwitchCase / Default pass, which makes nested switch migrations work.

fixes: angular#53009

PR Close angular#53010
amilamen pushed a commit to amilamen/angular that referenced this pull request Jan 26, 2024
…ngular#53010)

This separates out the NgSwitch migration pass from the NgSwitchCase / Default pass, which makes nested switch migrations work.

fixes: angular#53009

PR Close angular#53010
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update`/`ng generate` migrations target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

control flow migration: nested switches don't migrate properly

3 participants