fix(migrations): control flow migration fails for async pipe with unboxing of observable#52972
Closed
AnthonyFr75 wants to merge 1 commit intoangular:mainfrom
Closed
fix(migrations): control flow migration fails for async pipe with unboxing of observable#52972AnthonyFr75 wants to merge 1 commit intoangular:mainfrom
AnthonyFr75 wants to merge 1 commit intoangular:mainfrom
Conversation
jessicajaniuk
suggested changes
Nov 16, 2023
Contributor
jessicajaniuk
left a comment
There was a problem hiding this comment.
This looks great. Just need to add it to the other spots, too.
packages/core/schematics/ng-generate/control-flow-migration/ifs.ts
Outdated
Show resolved
Hide resolved
Contributor
|
@AnthonyFr75 Also, lint is failing because your commit is missing a body. While you're amending the commit, you could switch |
9f3fe6f to
7f598d4
Compare
jessicajaniuk
approved these changes
Nov 20, 2023
Contributor
jessicajaniuk
left a comment
There was a problem hiding this comment.
LGTM! Thanks for this!
packages/core/schematics/ng-generate/control-flow-migration/ifs.ts
Outdated
Show resolved
Hide resolved
7f598d4 to
8dd98ac
Compare
…oxing of observable (angular#52756) Update control flow syntax to use 'as' for proper async pipe handling, accounting for variable whitespace before 'let'. Fixes angular#52756
8dd98ac to
2ff3e40
Compare
Contributor
|
This PR was merged into the repository by commit e33f6e0. |
AndrewKushnir
pushed a commit
that referenced
this pull request
Nov 20, 2023
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…oxing of observable (angular#52756) (angular#52972) Update control flow syntax to use 'as' for proper async pipe handling, accounting for variable whitespace before 'let'. Fixes angular#52756 PR Close angular#52972
rlmestre
pushed a commit
to rlmestre/angular
that referenced
this pull request
Jan 26, 2024
…oxing of observable (angular#52756) (angular#52972) Update control flow syntax to use 'as' for proper async pipe handling, accounting for variable whitespace before 'let'. Fixes angular#52756 PR Close angular#52972
amilamen
pushed a commit
to amilamen/angular
that referenced
this pull request
Jan 26, 2024
…oxing of observable (angular#52756) (angular#52972) Update control flow syntax to use 'as' for proper async pipe handling, accounting for variable whitespace before 'let'. Fixes angular#52756 PR Close angular#52972
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update control flow syntax to use 'as' for proper async pipe handling, accounting for variable whitespace before 'let'.
Fixes #52756