fix: cta clickability issue in adev homepage.#52905
fix: cta clickability issue in adev homepage.#52905SahulKola wants to merge 1 commit intoangular:mainfrom
Conversation
| @@ -142,7 +142,8 @@ | |||
| display: inline-block; | |||
| padding: 7px; | |||
| opacity: 0; | |||
There was a problem hiding this comment.
Maybe we can remove opacity here and for .adev-arrow and use only visibility. WDYT?
There was a problem hiding this comment.
We use it for the transition.
| opacity: 0; | ||
| transition: opacity 0.5s linear; | ||
| visibility: hidden; | ||
| transition: opacity 0.5s linear, visibility 0.5s linear; |
There was a problem hiding this comment.
If transition doesn't work on visibility, we can remove it since we already have opacity.
There was a problem hiding this comment.
no, visibility prevents from being able to interact with it. So we're fine.
|
Deployed adev-preview for 4262663 to: https://ng-dev-previews-fw--pr-angular-angular-52905-adev-prev-lfcjn19y.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
jessicajaniuk
left a comment
There was a problem hiding this comment.
Verified this works. Looks great! Thank you!
|
This PR was merged into the repository by commit dfc6c8d. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: fixes #52900
What is the new behavior?
visibility: visibleby default, andvisibility: hiddenproperty on page scrollDoes this PR introduce a breaking change?
Other information