Skip to content

fix(migrations): Add missing support for ngForOf#52903

Closed
jessicajaniuk wants to merge 1 commit intoangular:mainfrom
jessicajaniuk:migrate-ngforof
Closed

fix(migrations): Add missing support for ngForOf#52903
jessicajaniuk wants to merge 1 commit intoangular:mainfrom
jessicajaniuk:migrate-ngforof

Conversation

@jessicajaniuk
Copy link
Copy Markdown
Contributor

This adds support to migrate ngForOf and ngForTrackBy when migrating control flow.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

@jessicajaniuk jessicajaniuk added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release area: migrations Issues related to `ng update`/`ng generate` migrations labels Nov 14, 2023
@ngbot ngbot bot modified the milestone: Backlog Nov 14, 2023
This adds support to migrate ngForOf and ngForTrackBy when migrating control flow.

export const ngfor = '*ngFor';
export const nakedngfor = 'ngFor';
const fors = [
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And also with you, @JoostK. :D

@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 15, 2023
@jessicajaniuk
Copy link
Copy Markdown
Contributor Author

This PR was merged into the repository by commit 8f5124e.

jessicajaniuk pushed a commit that referenced this pull request Nov 15, 2023
This adds support to migrate ngForOf and ngForTrackBy when migrating control flow.

PR Close #52903
@jessicajaniuk jessicajaniuk deleted the migrate-ngforof branch November 28, 2023 17:09
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 29, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
This adds support to migrate ngForOf and ngForTrackBy when migrating control flow.

PR Close angular#52903
rlmestre pushed a commit to rlmestre/angular that referenced this pull request Jan 26, 2024
This adds support to migrate ngForOf and ngForTrackBy when migrating control flow.

PR Close angular#52903
amilamen pushed a commit to amilamen/angular that referenced this pull request Jan 26, 2024
This adds support to migrate ngForOf and ngForTrackBy when migrating control flow.

PR Close angular#52903
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update`/`ng generate` migrations target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants