Skip to content

fix(migrations): passed in paths will be respected in nx workspaces#52796

Closed
jessicajaniuk wants to merge 1 commit intoangular:mainfrom
jessicajaniuk:migration-pathfix
Closed

fix(migrations): passed in paths will be respected in nx workspaces#52796
jessicajaniuk wants to merge 1 commit intoangular:mainfrom
jessicajaniuk:migration-pathfix

Conversation

@jessicajaniuk
Copy link
Copy Markdown
Contributor

@jessicajaniuk jessicajaniuk commented Nov 10, 2023

This fixes a bug where if you have multiple tsconfig files, the migration would not find anything to migrate at the passed in path. fixes: #52787

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • Yes
  • No

@thePunderWoman
fix(migrations): passed in paths will be respected in nx workspaces
67778cd 
This fixes a bug where if you have multiple tsconfig files, the migration would not find anything to migrate at the passed in path.
fixes: angular#52787
@jessicajaniuk jessicajaniuk added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release area: migrations Issues related to `ng update`/`ng generate` migrations labels Nov 10, 2023
@ngbot ngbot bot added this to the Backlog milestone Nov 10, 2023
@AndrewKushnir
Copy link
Copy Markdown
Contributor

AndrewKushnir commented Nov 10, 2023

@dgp1130 could you please help with the review for this PR?

dgp1130
dgp1130 approved these changes Nov 10, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@dgp1130 dgp1130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This does seem to be a somewhat recurring problem with tsconfig paths in Nx workspaces. I wonder if would be worth stepping back separately from this PR and looking at the problem a little more wholistically. Are there improvements we could make to testing or our schematics infrastructure which would catch this problem or make it "just work" by default without having to think about it?

@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 10, 2023
@jessicajaniuk jessicajaniuk removed the request for review from AndrewKushnir November 10, 2023 22:09
@jessicajaniuk
Copy link
Copy Markdown
Contributor Author

jessicajaniuk commented Nov 13, 2023

This PR was merged into the repository by commit da97bbc.

jessicajaniuk pushed a commit that referenced this pull request Nov 13, 2023
@thePunderWoman
fix(migrations): passed in paths will be respected in nx workspaces (#…
e1f84a3 
…52796)

This fixes a bug where if you have multiple tsconfig files, the migration would not find anything to migrate at the passed in path.
fixes: #52787

PR Close #52796
@jessicajaniuk jessicajaniuk deleted the migration-pathfix branch November 28, 2023 17:09
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Dec 29, 2023

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 29, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
@thePunderWoman @ChellappanRajan
fix(migrations): passed in paths will be respected in nx workspaces (a…
dd70c72 
…ngular#52796)

This fixes a bug where if you have multiple tsconfig files, the migration would not find anything to migrate at the passed in path.
fixes: angular#52787

PR Close angular#52796
rlmestre pushed a commit to rlmestre/angular that referenced this pull request Jan 26, 2024
@thePunderWoman @rlmestre
fix(migrations): passed in paths will be respected in nx workspaces (a…
c366953 
…ngular#52796)

This fixes a bug where if you have multiple tsconfig files, the migration would not find anything to migrate at the passed in path.
fixes: angular#52787

PR Close angular#52796
amilamen pushed a commit to amilamen/angular that referenced this pull request Jan 26, 2024
@thePunderWoman @amilamen
fix(migrations): passed in paths will be respected in nx workspaces (a…
0c29475 
…ngular#52796)

This fixes a bug where if you have multiple tsconfig files, the migration would not find anything to migrate at the passed in path.
fixes: angular#52787

PR Close angular#52796
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dgp1130 dgp1130 dgp1130 approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update`/`ng generate` migrations target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

Control Flow Migration Bug in Nx Workspace

4 participants

@jessicajaniuk @AndrewKushnir @dgp1130 @thePunderWoman