fix(core): handle non-container environment injector cases for getEnvironmentInjectorProviders#52774
Closed
AleksanderBodurri wants to merge 1 commit intoangular:mainfrom
Closed
Conversation
Previously we had logic for a special case where a root injector in standalone apps would skip the import paths calculation step for the `getEnvironmentInjectorProviders` function. This commit intends to fix this for two other cases, namely: - When an injector is created by a route (via the `providers` field and lazy loading). - When an injector is manually created and attached to the injector tree It does this by assuming that any environment injector it cannot find a provider imports container for was created without one, and simply returns the raw provider records without the import paths calculation.
f8a8333 to
6a01c7d
Compare
AndrewKushnir
approved these changes
Nov 10, 2023
Contributor
Contributor
|
This PR was merged into the repository by commit 6aef0f6. |
jessicajaniuk
pushed a commit
that referenced
this pull request
Nov 13, 2023
Previously we had logic for a special case where a root injector in standalone apps would skip the import paths calculation step for the `getEnvironmentInjectorProviders` function. This commit intends to fix this for two other cases, namely: - When an injector is created by a route (via the `providers` field and lazy loading). - When an injector is manually created and attached to the injector tree It does this by assuming that any environment injector it cannot find a provider imports container for was created without one, and simply returns the raw provider records without the import paths calculation. PR Close #52774
2 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…2774) Previously we had logic for a special case where a root injector in standalone apps would skip the import paths calculation step for the `getEnvironmentInjectorProviders` function. This commit intends to fix this for two other cases, namely: - When an injector is created by a route (via the `providers` field and lazy loading). - When an injector is manually created and attached to the injector tree It does this by assuming that any environment injector it cannot find a provider imports container for was created without one, and simply returns the raw provider records without the import paths calculation. PR Close angular#52774
rlmestre
pushed a commit
to rlmestre/angular
that referenced
this pull request
Jan 26, 2024
…2774) Previously we had logic for a special case where a root injector in standalone apps would skip the import paths calculation step for the `getEnvironmentInjectorProviders` function. This commit intends to fix this for two other cases, namely: - When an injector is created by a route (via the `providers` field and lazy loading). - When an injector is manually created and attached to the injector tree It does this by assuming that any environment injector it cannot find a provider imports container for was created without one, and simply returns the raw provider records without the import paths calculation. PR Close angular#52774
amilamen
pushed a commit
to amilamen/angular
that referenced
this pull request
Jan 26, 2024
…2774) Previously we had logic for a special case where a root injector in standalone apps would skip the import paths calculation step for the `getEnvironmentInjectorProviders` function. This commit intends to fix this for two other cases, namely: - When an injector is created by a route (via the `providers` field and lazy loading). - When an injector is manually created and attached to the injector tree It does this by assuming that any environment injector it cannot find a provider imports container for was created without one, and simply returns the raw provider records without the import paths calculation. PR Close angular#52774
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we had logic for a special case where a root injector in standalone apps would skip the import paths calculation step for the
getEnvironmentInjectorProvidersfunction.This commit intends to fix this for two other cases, namely:
providersfield and lazy loading).It does this by assuming that any environment injector it cannot find a provider imports container for was created without one, and simply returns the raw provider records without the import paths calculation.