Skip to content

fix(animations): prevent the AsyncAnimationRenderer from calling the delegate when there is no element.#52570

Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:fix/animations-builder
Closed

fix(animations): prevent the AsyncAnimationRenderer from calling the delegate when there is no element.#52570
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:fix/animations-builder

Conversation

@JeanMeche
Copy link
Copy Markdown
Member

@JeanMeche JeanMeche commented Nov 7, 2023

This happens when issueAnimationCommand is invoked

fixes #52538

@JeanMeche JeanMeche force-pushed the fix/animations-builder branch from df80d6b to ff43ae7 Compare November 8, 2023 08:05
@JeanMeche JeanMeche marked this pull request as ready for review November 8, 2023 08:05
@pullapprove pullapprove bot requested a review from alxhub November 8, 2023 08:05
@JeanMeche JeanMeche force-pushed the fix/animations-builder branch 2 times, most recently from 23fa504 to ec0d5ba Compare November 8, 2023 08:14
@jessicajaniuk jessicajaniuk added the area: animations legacy animations package only. Otherwise use area: core. label Nov 8, 2023
@ngbot ngbot bot added this to the Backlog milestone Nov 8, 2023
@JeanMeche JeanMeche force-pushed the fix/animations-builder branch 6 times, most recently from ce39d0c to 819ece7 Compare November 13, 2023 13:43
@JeanMeche
fix(animations): prevent the AsyncAnimationRenderer from calling the …
51e4810 
…delegate when there is no element.

This happens when `issueAnimationCommand` is invoked

fixes angular#52538
@JeanMeche JeanMeche force-pushed the fix/animations-builder branch from 819ece7 to 51e4810 Compare November 13, 2023 15:08
@jessicajaniuk jessicajaniuk added the target: patch This PR is targeted for the next patch release label Nov 13, 2023
jessicajaniuk
jessicajaniuk approved these changes Nov 13, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@jessicajaniuk jessicajaniuk removed the request for review from alxhub November 13, 2023 15:51
@jessicajaniuk jessicajaniuk added action: presubmit The PR is in need of a google3 presubmit action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit labels Nov 13, 2023
@jessicajaniuk
Copy link
Copy Markdown
Contributor

jessicajaniuk commented Nov 13, 2023

This PR was merged into the repository by commit 5ee11a7.

jessicajaniuk pushed a commit that referenced this pull request Nov 13, 2023
@JeanMeche @thePunderWoman
fix(animations): prevent the AsyncAnimationRenderer from calling the …
f5872c9 
…delegate when there is no element. (#52570)

This happens when `issueAnimationCommand` is invoked

fixes #52538

PR Close #52570
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Dec 14, 2023

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 14, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
@JeanMeche @ChellappanRajan
fix(animations): prevent the AsyncAnimationRenderer from calling the …
02aee8d 
…delegate when there is no element. (angular#52570)

This happens when `issueAnimationCommand` is invoked

fixes angular#52538

PR Close angular#52570
rlmestre pushed a commit to rlmestre/angular that referenced this pull request Jan 26, 2024
@JeanMeche @rlmestre
fix(animations): prevent the AsyncAnimationRenderer from calling the …
08994ec 
…delegate when there is no element. (angular#52570)

This happens when `issueAnimationCommand` is invoked

fixes angular#52538

PR Close angular#52570
amilamen pushed a commit to amilamen/angular that referenced this pull request Jan 26, 2024
@JeanMeche @amilamen
fix(animations): prevent the AsyncAnimationRenderer from calling the …
a456b22 
…delegate when there is no element. (angular#52570)

This happens when `issueAnimationCommand` is invoked

fixes angular#52538

PR Close angular#52570
@JeanMeche JeanMeche deleted the fix/animations-builder branch February 29, 2024 13:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jessicajaniuk jessicajaniuk jessicajaniuk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: animations legacy animations package only. Otherwise use area: core. target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

async animations: Cannot set properties of null (setting '@@0:register')

2 participants

@JeanMeche @jessicajaniuk