perf(core): optimize memory allocation when reconciling lists#52245
Closed
pkozlowski-opensource wants to merge 2 commits intoangular:mainfrom
Closed
perf(core): optimize memory allocation when reconciling lists#52245pkozlowski-opensource wants to merge 2 commits intoangular:mainfrom
pkozlowski-opensource wants to merge 2 commits intoangular:mainfrom
Conversation
JoostK
reviewed
Oct 17, 2023
JoostK
reviewed
Oct 17, 2023
cf9fa4b to
3e1ab2c
Compare
JoostK
reviewed
Oct 17, 2023
3e1ab2c to
1a25809
Compare
This change replaces the implementation of the multi-map used to store detached views while reconciling lists. The new implementation optimizes memory allocation for such map and avoid arrays allocation when there are no duplicated keys.
55e824e to
23f6cfa
Compare
Member
Author
|
@JoostK I believe I've addressed all the feedback (thnx for the review!) - could you please take another look? |
JoostK
approved these changes
Dec 6, 2023
Member
There was a problem hiding this comment.
nit: could possibly move this above the if and use it in the condition as well. Only relevant for minification now, as perf should be fine without this local variable either way.
Member
Author
|
|
23f6cfa to
48c9d54
Compare
Member
|
This PR was merged into the repository by commit e3a6bf9. |
alxhub
pushed a commit
that referenced
this pull request
Dec 8, 2023
This change replaces the implementation of the multi-map used to store detached views while reconciling lists. The new implementation optimizes memory allocation for such map and avoid arrays allocation when there are no duplicated keys. PR Close #52245
dylhunn
pushed a commit
to dylhunn/angular
that referenced
this pull request
Dec 11, 2023
…ar#52245) This change replaces the implementation of the multi-map used to store detached views while reconciling lists. The new implementation optimizes memory allocation for such map and avoid arrays allocation when there are no duplicated keys. PR Close angular#52245
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…ar#52245) This change replaces the implementation of the multi-map used to store detached views while reconciling lists. The new implementation optimizes memory allocation for such map and avoid arrays allocation when there are no duplicated keys. PR Close angular#52245
rlmestre
pushed a commit
to rlmestre/angular
that referenced
this pull request
Jan 26, 2024
…ar#52245) This change replaces the implementation of the multi-map used to store detached views while reconciling lists. The new implementation optimizes memory allocation for such map and avoid arrays allocation when there are no duplicated keys. PR Close angular#52245
amilamen
pushed a commit
to amilamen/angular
that referenced
this pull request
Jan 26, 2024
…ar#52245) This change replaces the implementation of the multi-map used to store detached views while reconciling lists. The new implementation optimizes memory allocation for such map and avoid arrays allocation when there are no duplicated keys. PR Close angular#52245
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change replaces the implementation of the multi-map used to store detached views while reconciling lists. The new implementation optimizes memory allocation for such map and avoid arrays allocation when there are no duplicated keys.