Conversation
2e35646 to
ca647a0
Compare
55234b0 to
9b5fe3f
Compare
There was a problem hiding this comment.
In general I think this type of algorithm is a really good case for descriptive comments - what state are we in? What just happened? What needs to happen next? etc.
There was a problem hiding this comment.
I think I see a way of combining these algorithms to lower the code size here.
The fundamental observation is to note that lines 98-134 are the only place we need random (tail) access to the collection. Otherwise, we're only ever looking at the "next" item and could go through an iterator if needed.
I don't think we need to do this refactoring before landing this change, but we should talk about it.
There was a problem hiding this comment.
Agreed. Will try different refactorings here but it would be great if we can do it post feature freeze. Let's chat / pair.
de35c62 to
9dc24da
Compare
The new list reconcilation algorithm, an alternative to the DefaultIterableListDiffer. It works by performing updates in place instead of creating intermediate data describing changes to apply. For lists expressed as an Array it performs additional optimizations for the moves and swap scenarios. The new list diffing approach is meant to be used in the new control flow and should me much faster as compared to the ngFor with the DefaultIterableListDiffer.
This commit plugs the new list reconciliation into the new built-in repeater.
9dc24da to
028a6f0
Compare
|
This PR was merged into the repository by commit 7d42dc3. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
The new list reconcilation algorithm, an alternative to the DefaultIterableListDiffer. It works by performing updates in place instead of creating intermediate data describing changes to apply. For lists expressed as an Array it performs additional optimizations for the moves and swap scenarios. The new list diffing approach is meant to be used in the new control flow and should me much faster as compared to the ngFor with the DefaultIterableListDiffer. PR Close angular#51980
…ngular#51980) This commit plugs the new list reconciliation into the new built-in repeater. PR Close angular#51980
No description provided.