fix(core): Ensure backwards-referenced transplanted views are refreshed#51854
Closed
atscott wants to merge 1 commit intoangular:mainfrom
Closed
fix(core): Ensure backwards-referenced transplanted views are refreshed#51854atscott wants to merge 1 commit intoangular:mainfrom
atscott wants to merge 1 commit intoangular:mainfrom
Conversation
dylhunn
approved these changes
Sep 22, 2023
Contributor
dylhunn
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
jessicajaniuk
approved these changes
Sep 22, 2023
Contributor
jessicajaniuk
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
alxhub
approved these changes
Sep 29, 2023
dbb2283 to
0cd776b
Compare
There was a problem hiding this comment.
As far as I remember we were discussing lowering this number?
Contributor
Author
There was a problem hiding this comment.
I do not recall this conversation. But the number is an arbitrary decision by me. I have no opinions on what it should be.
This commit runs change detection in a loop while there are still dirty views to be refreshed in the tree. At the moment, this only applies to transplanted views but will also apply to views with changed signals. fixes angular#49801
0cd776b to
14734ac
Compare
Contributor
Author
Contributor
Author
|
caretaker: green TGP, current failures are existing failures |
Contributor
|
This PR was merged into the repository by commit 76152a5. |
atscott
added a commit
to atscott/angular
that referenced
this pull request
Nov 2, 2023
…tion The significance of the combination of angular#51854 and angular#52302 went mostly unnoticed. The first removed a unidirectional data flow constraint for transplanted views and the second updated the signal implementation to share transplanted view logic. The result is that we automatically get behavior that (mostly) removes `ExpressionChangedAfterItWasCheckedError` when signals are used to drive application state to DOM synchronization. fixes angular#50320
alxhub
pushed a commit
that referenced
this pull request
Nov 2, 2023
…tion (#52476) The significance of the combination of #51854 and #52302 went mostly unnoticed. The first removed a unidirectional data flow constraint for transplanted views and the second updated the signal implementation to share transplanted view logic. The result is that we automatically get behavior that (mostly) removes `ExpressionChangedAfterItWasCheckedError` when signals are used to drive application state to DOM synchronization. fixes #50320 PR Close #52476
alxhub
pushed a commit
that referenced
this pull request
Nov 2, 2023
…tion (#52476) The significance of the combination of #51854 and #52302 went mostly unnoticed. The first removed a unidirectional data flow constraint for transplanted views and the second updated the signal implementation to share transplanted view logic. The result is that we automatically get behavior that (mostly) removes `ExpressionChangedAfterItWasCheckedError` when signals are used to drive application state to DOM synchronization. fixes #50320 PR Close #52476
Abseil-byte
pushed a commit
to Abseil-byte/angular
that referenced
this pull request
Nov 5, 2023
…tion (angular#52476) The significance of the combination of angular#51854 and angular#52302 went mostly unnoticed. The first removed a unidirectional data flow constraint for transplanted views and the second updated the signal implementation to share transplanted view logic. The result is that we automatically get behavior that (mostly) removes `ExpressionChangedAfterItWasCheckedError` when signals are used to drive application state to DOM synchronization. fixes angular#50320 PR Close angular#52476
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…ed (angular#51854) This commit runs change detection in a loop while there are still dirty views to be refreshed in the tree. At the moment, this only applies to transplanted views but will also apply to views with changed signals. fixes angular#49801 PR Close angular#51854
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based off of https://github.com/angular/angular/pull/51515This commit runs change detection in a loop while there are still dirty
views to be refreshed in the tree. At the moment, this only applies to
transplanted views but will also apply to views with changed signals.
fixes #49801