Skip to content

fix(core): guard the jasmine hooks#51394

Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:fix/hooks
Closed

fix(core): guard the jasmine hooks#51394
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:fix/hooks

Conversation

@JeanMeche
Copy link
Copy Markdown
Member

@JeanMeche JeanMeche commented Aug 16, 2023

This commit fixes a regression introduced in #50063

Fixes #51382

@pullapprove pullapprove bot requested review from crisbeto and dylhunn August 16, 2023 21:11
JoostK
JoostK reviewed Aug 16, 2023
View reviewed changes
@JeanMeche JeanMeche force-pushed the fix/hooks branch 2 times, most recently from 4cdd996 to 406f235 Compare August 16, 2023 21:37
@JeanMeche
fix(core): guard the jasmine hooks
3198a86 
This commit fixes a regression introduced in angular#50063

Fixes angular#51382
@JoostK JoostK added action: review The PR is still awaiting reviews from at least one requested reviewer regression Indicates than the issue relates to something that worked in a previous version area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release P2 The issue is important to a large percentage of users, with a workaround labels Aug 17, 2023
@ngbot ngbot bot added this to the Backlog milestone Aug 17, 2023
@AndrewKushnir
Copy link
Copy Markdown
Contributor

AndrewKushnir commented Aug 20, 2023

Global Presubmit.

@AndrewKushnir AndrewKushnir added the action: global presubmit The PR is in need of a google3 global presubmit label Aug 20, 2023
@AndrewKushnir
Copy link
Copy Markdown
Contributor

AndrewKushnir commented Aug 20, 2023

Caretaker note: global presubmit is "green", this PR is ready for merge.

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer action: global presubmit The PR is in need of a google3 global presubmit labels Aug 20, 2023
@AndrewKushnir
Copy link
Copy Markdown
Contributor

AndrewKushnir commented Aug 21, 2023

This PR was merged into the repository by commit a9b3c00.

AndrewKushnir pushed a commit that referenced this pull request Aug 21, 2023
@JeanMeche @AndrewKushnir
fix(core): guard the jasmine hooks (#51394)
36f434e 
This commit fixes a regression introduced in #50063

Fixes #51382

PR Close #51394
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 21, 2023

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 21, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
@JeanMeche @ChellappanRajan
fix(core): guard the jasmine hooks (angular#51394)
b59066d 
This commit fixes a regression introduced in angular#50063

Fixes angular#51382

PR Close angular#51394
@JeanMeche JeanMeche deleted the fix/hooks branch February 29, 2024 13:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JoostK JoostK JoostK left review comments

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note P2 The issue is important to a large percentage of users, with a workaround regression Indicates than the issue relates to something that worked in a previous version target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

Uncaught ReferenceError: beforeEach is not defined

3 participants

@JeanMeche @AndrewKushnir @JoostK