fix(http): check whether Zone is defined#51119
Closed
arturovt wants to merge 1 commit intoangular:mainfrom
Closed
Conversation
Accessing the `Zone` variable without checking if it's defined or not leads to an error "Zone is not defined" if zone.js is not imported (nooped). This commit adds an additional check before getting the current zone where the `doRequest` is being called.
AndrewKushnir
approved these changes
Jul 21, 2023
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
@arturovt thanks for the improvement!
Contributor
|
This PR was merged into the repository by commit 57e8412. |
jessicajaniuk
pushed a commit
that referenced
this pull request
Jul 21, 2023
Accessing the `Zone` variable without checking if it's defined or not leads to an error "Zone is not defined" if zone.js is not imported (nooped). This commit adds an additional check before getting the current zone where the `doRequest` is being called. PR Close #51119
sunilbaba
pushed a commit
to sunilbaba/angular
that referenced
this pull request
Jul 26, 2023
Accessing the `Zone` variable without checking if it's defined or not leads to an error "Zone is not defined" if zone.js is not imported (nooped). This commit adds an additional check before getting the current zone where the `doRequest` is being called. PR Close angular#51119
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
Accessing the `Zone` variable without checking if it's defined or not leads to an error "Zone is not defined" if zone.js is not imported (nooped). This commit adds an additional check before getting the current zone where the `doRequest` is being called. PR Close angular#51119
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accessing the
Zonevariable without checking if it's defined or not leads to an error "Zone is not defined" if zone.js is not imported (nooped). This commit adds an additional check before getting the current zone where thedoRequestis being called.