perf(platform-browser): do not remove renderer from cache when REMOVE_STYLES_ON_COMPONENT_DESTROY is enabled.#51005
Closed
alan-agius4 wants to merge 1 commit intoangular:mainfrom
Closed
perf(platform-browser): do not remove renderer from cache when REMOVE_STYLES_ON_COMPONENT_DESTROY is enabled.#51005alan-agius4 wants to merge 1 commit intoangular:mainfrom
REMOVE_STYLES_ON_COMPONENT_DESTROY is enabled.#51005alan-agius4 wants to merge 1 commit intoangular:mainfrom
Conversation
…E_STYLES_ON_COMPONENT_DESTROY` is enabled. Removing the renderer from cache is not needed when `REMOVE_STYLES_ON_COMPONENT_DESTROY` is enabled. This change retains the behaviour of keeping the renderer cached for the entire lifecycle of the application the same way it is done when `REMOVE_STYLES_ON_COMPONENT_DESTROY` is disabled. This seems to have be causing an increase in scripting. See: http://b/290666638
AndrewKushnir
approved these changes
Jul 11, 2023
Contributor
|
This PR was merged into the repository by commit f1b6299. |
dylhunn
pushed a commit
that referenced
this pull request
Jul 11, 2023
…E_STYLES_ON_COMPONENT_DESTROY` is enabled. (#51005) Removing the renderer from cache is not needed when `REMOVE_STYLES_ON_COMPONENT_DESTROY` is enabled. This change retains the behaviour of keeping the renderer cached for the entire lifecycle of the application the same way it is done when `REMOVE_STYLES_ON_COMPONENT_DESTROY` is disabled. This seems to have be causing an increase in scripting. See: http://b/290666638 PR Close #51005
sunilbaba
pushed a commit
to sunilbaba/angular
that referenced
this pull request
Jul 26, 2023
…E_STYLES_ON_COMPONENT_DESTROY` is enabled. (angular#51005) Removing the renderer from cache is not needed when `REMOVE_STYLES_ON_COMPONENT_DESTROY` is enabled. This change retains the behaviour of keeping the renderer cached for the entire lifecycle of the application the same way it is done when `REMOVE_STYLES_ON_COMPONENT_DESTROY` is disabled. This seems to have be causing an increase in scripting. See: http://b/290666638 PR Close angular#51005
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…E_STYLES_ON_COMPONENT_DESTROY` is enabled. (angular#51005) Removing the renderer from cache is not needed when `REMOVE_STYLES_ON_COMPONENT_DESTROY` is enabled. This change retains the behaviour of keeping the renderer cached for the entire lifecycle of the application the same way it is done when `REMOVE_STYLES_ON_COMPONENT_DESTROY` is disabled. This seems to have be causing an increase in scripting. See: http://b/290666638 PR Close angular#51005
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing the renderer from cache is not needed when
REMOVE_STYLES_ON_COMPONENT_DESTROYis enabled. This change retains the behaviour of keeping the renderer cached for the entire lifecycle of the application the same way it is done whenREMOVE_STYLES_ON_COMPONENT_DESTROYis disabled.This seems to have be causing an increase in scripting. See: http://b/290666638