fix(platform-browser): wait until animation completion before destroying renderer#50860
Closed
alan-agius4 wants to merge 2 commits intoangular:mainfrom
Closed
fix(platform-browser): wait until animation completion before destroying renderer#50860alan-agius4 wants to merge 2 commits intoangular:mainfrom
alan-agius4 wants to merge 2 commits intoangular:mainfrom
Conversation
Contributor
Author
|
Caretaker note: This is a resubmission of #50677 as it was reverted due to needing more coordination to sync in G3.
|
477a094 to
04d1fac
Compare
…ing renderer Prior to this commit, the renderer destroy method was being called before the animation complete. This is problematic when using `REMOVE_STYLES_ON_COMPONENT_DESTROY` as it causes the styles to be removed too early. This commit, updates this destroy logic to be call the render destroy once the animations complete. This has been reported internally in: - http://b/271251353#comment12 - http://b/282004950#comment5
This commit removes unnecessary castings.
04d1fac to
c53b9d8
Compare
AndrewKushnir
approved these changes
Jun 27, 2023
Contributor
|
This PR was merged into the repository by commit 29f6912. |
AndrewKushnir
pushed a commit
that referenced
this pull request
Jun 27, 2023
…ing renderer (#50860) Prior to this commit, the renderer destroy method was being called before the animation complete. This is problematic when using `REMOVE_STYLES_ON_COMPONENT_DESTROY` as it causes the styles to be removed too early. This commit, updates this destroy logic to be call the render destroy once the animations complete. This has been reported internally in: - http://b/271251353#comment12 - http://b/282004950#comment5 PR Close #50860
AndrewKushnir
pushed a commit
that referenced
this pull request
Jun 27, 2023
This commit removes unnecessary castings. PR Close #50860
AndrewKushnir
pushed a commit
that referenced
this pull request
Jun 27, 2023
This commit removes unnecessary castings. PR Close #50860
sunilbaba
pushed a commit
to sunilbaba/angular
that referenced
this pull request
Jul 26, 2023
…ing renderer (angular#50860) Prior to this commit, the renderer destroy method was being called before the animation complete. This is problematic when using `REMOVE_STYLES_ON_COMPONENT_DESTROY` as it causes the styles to be removed too early. This commit, updates this destroy logic to be call the render destroy once the animations complete. This has been reported internally in: - http://b/271251353#comment12 - http://b/282004950#comment5 PR Close angular#50860
sunilbaba
pushed a commit
to sunilbaba/angular
that referenced
this pull request
Jul 26, 2023
This commit removes unnecessary castings. PR Close angular#50860
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…ing renderer (angular#50860) Prior to this commit, the renderer destroy method was being called before the animation complete. This is problematic when using `REMOVE_STYLES_ON_COMPONENT_DESTROY` as it causes the styles to be removed too early. This commit, updates this destroy logic to be call the render destroy once the animations complete. This has been reported internally in: - http://b/271251353#comment12 - http://b/282004950#comment5 PR Close angular#50860
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
This commit removes unnecessary castings. PR Close angular#50860
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the renderer destroy method was being called before the animation complete. This is problematic when using
REMOVE_STYLES_ON_COMPONENT_DESTROYas it causes the styles to be removed too early.This commit, updates this destroy logic to be call the render destroy once the animations complete.
This has been reported internally in: