feat(core): add afterRender and afterNextRender#50607
Closed
devknoll wants to merge 1 commit intoangular:mainfrom
Closed
feat(core): add afterRender and afterNextRender#50607devknoll wants to merge 1 commit intoangular:mainfrom
afterRender and afterNextRender#50607devknoll wants to merge 1 commit intoangular:mainfrom
Conversation
devknoll
commented
Jun 7, 2023
6d80614 to
facf9f0
Compare
701205b to
07fd41f
Compare
07fd41f to
7d1ffc9
Compare
This comment was marked as outdated.
This comment was marked as outdated.
294db1b to
76fb2e5
Compare
Contributor
There was a problem hiding this comment.
@devknoll thanks for the updates (I've just left a few comments) 👍
Another questions/items worth considering:
- we should consider running performance tests, since we are adding code to the "hot" code path
- we need to finalize function names and what those functions return
- we can also discuss how to make the implementation tree-shakable (since it has a bit more code now), i.e. don't include the
AfterRenderHooksManagercode unless theafterRenderorafterNextRenderfunction is used - it'd be great to put together some tests into hydration spec and assert that the lifecycle hook is being invoked once hydration is completed
ae8aa78 to
baef737
Compare
AndrewKushnir
approved these changes
Jul 28, 2023
AndrewKushnir
approved these changes
Jul 28, 2023
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
jessicajaniuk
approved these changes
Jul 31, 2023
Contributor
jessicajaniuk
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
0063ca9 to
3627363
Compare
Add and expose the after*Render functions as developer preview
3627363 to
67dbe29
Compare
Contributor
AndrewKushnir
approved these changes
Aug 1, 2023
Contributor
|
Caretaker notes:
This PR is now ready for merge. |
Member
|
This PR was merged into the repository by commit e53d4ec. |
This was referenced Aug 9, 2023
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
Add and expose the after*Render functions as developer preview PR Close angular#50607
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information