refactor: remove deprecated EventManager method addGlobalEventListener#49645
Closed
alan-agius4 wants to merge 1 commit intoangular:mainfrom
Closed
refactor: remove deprecated EventManager method addGlobalEventListener#49645alan-agius4 wants to merge 1 commit intoangular:mainfrom
EventManager method addGlobalEventListener#49645alan-agius4 wants to merge 1 commit intoangular:mainfrom
Conversation
ff2bac7 to
c357532
Compare
Member
|
Yay! 🎉 |
5e11015 to
8bd31ee
Compare
…ener` This commit removed the deprecated `EventManager` method `addGlobalEventListener`. BREAKING CHANGE: Deprecated `EventManager` method `addGlobalEventListener` has been removed as it is not used by Ivy.
8bd31ee to
21492fc
Compare
EventManager method `addGlobalEventList…EventManager method addGlobalEventListener
pkozlowski-opensource
approved these changes
Mar 30, 2023
Member
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
Thnx for the cleanup, I had it on one of my TODO lists, happy to see it removed!
pkozlowski-opensource
approved these changes
Mar 30, 2023
Member
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: public-api
Reviewed-for: fw-core
Reviewed-for: fw-platform-server
Contributor
Author
Haha no problem. |
Contributor
Author
|
|
atscott
approved these changes
Mar 30, 2023
atscott
approved these changes
Mar 30, 2023
Contributor
atscott
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
Contributor
|
This PR was merged into the repository by commit 2703fd6. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the deprecated
EventManagermethodaddGlobalEventListener.BREAKING CHANGE: Deprecated
EventManagermethodaddGlobalEventListenerhas been removed as it is not used by Ivy.