feat(core): Drop public factories property for IterableDiffers#49598
Closed
JeanMeche wants to merge 2 commits intoangular:mainfrom
Closed
feat(core): Drop public factories property for IterableDiffers#49598JeanMeche wants to merge 2 commits intoangular:mainfrom
factories property for IterableDiffers#49598JeanMeche wants to merge 2 commits intoangular:mainfrom
Conversation
e7c1613 to
7e8200a
Compare
Contributor
|
@JeanMeche While I don't expect anyone to really be using this, can you still add the "breaking change" footer to this commit? |
atscott
approved these changes
Mar 27, 2023
jessicajaniuk
approved these changes
Mar 28, 2023
Contributor
jessicajaniuk
left a comment
There was a problem hiding this comment.
reviewed-for: fw-core, public-api
Contributor
|
@JeanMeche Looks like this might need a rebase? If it's otherwise ready to go, please @ me once rebased, thanks. |
dylhunn
approved these changes
Apr 4, 2023
Contributor
dylhunn
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
…Breaking change The `factories` property was marked as deprecated in v4 to make it private. Let's move it to private.
Remove some `any` and use the non-deprecated `Injector.create` overload.
7e8200a to
cc13542
Compare
Member
Author
|
@dylhunn Done ! |
Contributor
|
This PR was merged into the repository by commit 1aef29c. |
dylhunn
pushed a commit
that referenced
this pull request
Apr 4, 2023
Remove some `any` and use the non-deprecated `Injector.create` overload. PR Close #49598
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing the public from
IterableDiffers'sfactorieswhich was deprecated long time ago. Also there is a quick cleanup of the related tests.Let me know if the breaking change requires some work.
Does this PR introduce a breaking change?