Skip to content

fix(router): Ensure initial navigation clears current navigation when…#49572

Closed
atscott wants to merge 1 commit intoangular:mainfrom
atscott:completethenavigation
Closed

fix(router): Ensure initial navigation clears current navigation when…#49572
atscott wants to merge 1 commit intoangular:mainfrom
atscott:completethenavigation

Conversation

@atscott
Copy link
Contributor

@atscott atscott commented Mar 23, 2023

… blocking

The navigation transition clears the current navigation in the finalize operator of the current navigation Observer. This commit both completes the bootstrapDone observable and updates the transition to only take 1 emit from the completed navigation. Either of these changes on their own would fix the issue. The latter is a preventative measure in case a mistake like the former is made again.

fixes #49567

@atscott atscott added the target: patch This PR is targeted for the next patch release label Mar 23, 2023
@atscott atscott force-pushed the completethenavigation branch from 7b23626 to 0dc2a4a Compare March 23, 2023 18:27
@atscott atscott requested a review from AndrewKushnir March 30, 2023 23:41
@atscott atscott force-pushed the completethenavigation branch from 0dc2a4a to bbcdf15 Compare March 30, 2023 23:41
@ngbot ngbot bot added this to the Backlog milestone Mar 30, 2023
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

… blocking

The navigation transition clears the current navigation in the finalize
operator of the current navigation Observer. This commit both completes
the `bootstrapDone` observable and updates the transition to only take 1
emit from the completed navigation. Either of these changes on their own
would fix the issue. The latter is a preventative measure in case a
mistake like the former is made again.

fixes angular#49567
@atscott atscott force-pushed the completethenavigation branch from bbcdf15 to dc7ead4 Compare March 30, 2023 23:49
@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Mar 31, 2023
@ngbot
Copy link

ngbot bot commented Mar 31, 2023

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "google-internal-tests" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@dylhunn
Copy link
Contributor

dylhunn commented Mar 31, 2023

It looks like the TAP failure is unrelated, but just checking with you @atscott to be sure?

@atscott atscott added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Mar 31, 2023
@atscott
Copy link
Contributor Author

atscott commented Mar 31, 2023

caretaker: TAP failure is unrelated (already failing at head and flaky)

@dylhunn
Copy link
Contributor

dylhunn commented Apr 1, 2023

This PR was merged into the repository by commit fa3909e.

@dylhunn dylhunn closed this in fa3909e Apr 1, 2023
dylhunn pushed a commit that referenced this pull request Apr 1, 2023
… blocking (#49572)

The navigation transition clears the current navigation in the finalize
operator of the current navigation Observer. This commit both completes
the `bootstrapDone` observable and updates the transition to only take 1
emit from the completed navigation. Either of these changes on their own
would fix the issue. The latter is a preventative measure in case a
mistake like the former is made again.

fixes #49567

PR Close #49572
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Apr 9, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`15.2.5` -> `15.2.6`](https://renovatebot.com/diffs/npm/@angular%2fanimations/15.2.5/15.2.6) |
| [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`15.2.5` -> `15.2.6`](https://renovatebot.com/diffs/npm/@angular%2fcommon/15.2.5/15.2.6) |
| [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`15.2.5` -> `15.2.6`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/15.2.5/15.2.6) |
| [@angular/compiler-cli](https://github.com/angular/angular/tree/main/packages/compiler-cli) ([source](https://github.com/angular/angular)) | devDependencies | patch | [`15.2.5` -> `15.2.6`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/15.2.5/15.2.6) |
| [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`15.2.5` -> `15.2.6`](https://renovatebot.com/diffs/npm/@angular%2fcore/15.2.5/15.2.6) |
| [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`15.2.5` -> `15.2.6`](https://renovatebot.com/diffs/npm/@angular%2fforms/15.2.5/15.2.6) |
| [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`15.2.5` -> `15.2.6`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/15.2.5/15.2.6) |
| [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`15.2.5` -> `15.2.6`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/15.2.5/15.2.6) |

---

### Release Notes

<details>
<summary>angular/angular</summary>

### [`v15.2.6`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#&#8203;1526-2023-04-05)

[Compare Source](angular/angular@15.2.5...15.2.6)

##### core

| Commit | Type | Description |
| -- | -- | -- |
| [d9efa1b0d7](angular/angular@d9efa1b) | feat | change the URL sanitization to only block javascript: URLs ([#&#8203;49659](angular/angular#49659)) |

##### router

| Commit | Type | Description |
| -- | -- | -- |
| [cad7274ef9](angular/angular@cad7274) | fix | create correct URL relative to path with empty child ([#&#8203;49691](angular/angular#49691)) |
| [9b61379096](angular/angular@9b61379) | fix | Ensure initial navigation clears current navigation when blocking ([#&#8203;49572](angular/angular#49572)) |

#### Special Thanks

Andrew Scott, Guillaume Weghsteen, John Manners, Johnny Gérard, Matthieu Riegler, Robin Richtsfeld, Sandra Limacher, Sarthak Thakkar, Vinit Neogi and vikram menon

<!-- CHANGELOG SPLIT MARKER -->

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4zNC4wIiwidXBkYXRlZEluVmVyIjoiMzUuMzguMCJ9-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1851
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: router merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

With InitialNavigation.enabledBlocking the initial navigation doesn't get completed

3 participants