refactor(core): Remove ReflectiveInjector symbol#48103
Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
Closed
refactor(core): Remove ReflectiveInjector symbol#48103JeanMeche wants to merge 1 commit intoangular:mainfrom
ReflectiveInjector symbol#48103JeanMeche wants to merge 1 commit intoangular:mainfrom
Conversation
7538758 to
08d729b
Compare
josephperrott
approved these changes
Nov 17, 2022
Member
josephperrott
left a comment
There was a problem hiding this comment.
LGTM
This is a breaking change and can't land until v16
Reviewed-for: benchpress
dylhunn
approved these changes
Nov 17, 2022
Contributor
dylhunn
left a comment
There was a problem hiding this comment.
reviewed-for: fw-core, fw-benchmarks
Contributor
|
@JeanMeche could you please rebase this PR (and resolve conflicts) when you get a chance? We'll try to perform the necessary cleanup in Google's codebase by v16 to unblock this. |
62d0be0 to
63d6ead
Compare
Contributor
63d6ead to
22ba849
Compare
Contributor
AndrewKushnir
approved these changes
Apr 4, 2023
jessicajaniuk
approved these changes
Apr 4, 2023
Contributor
jessicajaniuk
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
AndrewKushnir
approved these changes
Apr 4, 2023
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
The `ReflectiveInjector` symbol has been deprecated in v5 (11 major versions ago). This commit removes ReflectiveInjector and related symbols. BREAKING CHANGE: The `ReflectiveInjector` and related symbols were removed. Please update the code to avoid references to the `ReflectiveInjector` symbol. Use `Injector.create` as a replacement to create an injector instead.
ab315d7 to
a4c02c3
Compare
jessicajaniuk
approved these changes
Apr 4, 2023
Contributor
jessicajaniuk
left a comment
There was a problem hiding this comment.
reviewed-for: public-api, circular-dependencies
Contributor
|
Caretaker note: g3 cleanup is completed 🎉 This PR is now ready for merge (once CI run is completed). Please sync this PR into g3 as a separate change. |
ReflectiveInjector symbol
Contributor
|
This PR was merged into the repository by commit 3b863dd. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReflectiveInjector has been replaced since v5 and deprecated in v8, let's remove this.
Does this PR introduce a breaking change?
What are the impacts at google ? Is this API still used ?