perf(router): Use .bind to avoid holding other closures in memory

DavidANeil · leonsenft · commit 3867cd85545b · 2026-02-03T12:24:58.000-08:00
In many JS runtimes all closures created in the same scope share a context
this means that data held in one of the closures is not collected until all of the closures are collected.
This change prevents the returned promise from holding a reaction that holds the entire `Router` object in memory.
diff --git a/packages/router/src/router.ts b/packages/router/src/router.ts
@@ -697,9 +697,8 @@ export class Router {
 
     // Make sure that the error is propagated even though `processNavigations` catch
     // handler does not rethrow
-    return promise.catch((e: any) => {
-      return Promise.reject(e);
-    });
+    // perf: Use `.bind` to avoid holding the other closures in this scope while this promise is unsettled.
+    return promise.catch(Promise.reject.bind(Promise));
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -697,9 +697,8 @@ export class Router {`
`697`	`697`
`698`	`698`	// Make sure that the error is propagated even though `processNavigations` catch
`699`	`699`	`// handler does not rethrow`
`700`		`- return promise.catch((e: any) => {`
`701`		`- return Promise.reject(e);`
`702`		`- });`
	`700`	+ // perf: Use `.bind` to avoid holding the other closures in this scope while this promise is unsettled.
	`701`	`+ return promise.catch(Promise.reject.bind(Promise));`
`703`	`702`	`}`
`704`	`703`	`}`
`705`	`704`