Skip to content

docs: Remove synchronize trigger#281

Merged
amannn merged 1 commit intoamannn:mainfrom
jguddas:patch-1
Apr 28, 2025
Merged

docs: Remove synchronize trigger#281
amannn merged 1 commit intoamannn:mainfrom
jguddas:patch-1

Conversation

@jguddas
Copy link
Copy Markdown
Contributor

@jguddas jguddas commented Apr 26, 2025

I don't think this trigger is necessary and needlessly increases cost.

amannn
amannn reviewed Apr 27, 2025
View reviewed changes
Copy link
Copy Markdown
Owner

@amannn amannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I think you're right!

Can you modify the workflows in .github to remove this trigger when used in combination with action-semantic-pull-request?

@jguddas
Copy link
Copy Markdown
Contributor Author

jguddas commented Apr 27, 2025 •
edited
Loading

Can you modify the workflows in .github to remove this trigger when used in combination with action-semantic-pull-request?

I would keep it, since you could be pushing changes to ./action.yml and then you want to see them take effect.

Same issue I guess for people who edit the settings of the workflow.

Example:

  1. I create a PR.
  2. I add new type to my .github/workflows/lint-pr-title.yml and push that change to my existing PR.
  3. Workflow does not automatically rerun since there is no trigger.

I'm still of the opinion we should remove the trigger from the docs, we are just burning money 💸💸💸

amannn
amannn approved these changes Apr 28, 2025
View reviewed changes
Copy link
Copy Markdown
Owner

@amannn amannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point, let's leave it like this then.

I agree, for pretty much every case it's not needed to run on synchronize.

@amannn amannn changed the title docs: removes synchronize trigger docs: Remove synchronize trigger Apr 28, 2025
@amannn amannn merged commit 3352882 into amannn:main Apr 28, 2025
2 checks passed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 13, 2025

🎉 This PR is included in version 6.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@amannn amannn mentioned this pull request Nov 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amannn amannn amannn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jguddas @amannn