feat(languages): add support for PowerShell#276
Merged
alstr merged 2 commits intoalstr:masterfrom Jul 10, 2025
RomainChamb:add-powershell-support
Merged
feat(languages): add support for PowerShell#276alstr merged 2 commits intoalstr:masterfrom RomainChamb:add-powershell-support
alstr merged 2 commits intoalstr:masterfrom
RomainChamb:add-powershell-support
Conversation
Author
|
Hi guys, |
Owner
|
Thanks for the PR, it all looks good to me from here, I think the test is just failing because of the hardcoded number we have in I think we just need to update that to 87 to account for the new TODOs added to the test file. This is a bit unclear as it stands, so I will make a note to mention it in the README and PR template. Thanks! |
Author
|
Thank you for your message. |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Language Name: PowerShell
Checklist for Adding a New Language
Before submitting your pull request, please ensure the following requirements are met:
syntax.jsonwith the language name matching that in GitHub's Linguistlanguages.ymlfile.test_new.diffandtest_closed.diff.test_todo_parser.py. The tests should check that theace_modeof the issue matches that specified in thelanguages.ymlfile. If existing checks for thatace_modeexists, I have incremented them instead.README.mdto add the language.