ci: Consolidate workflows#439
Merged
alexcrichton merged 2 commits intoalexcrichton:mainfrom Mar 10, 2026
Merged
Conversation
Merge the separate main.yml and revdep.yml workflow files into a single ci.yml. This makes it possible to configure a single 'required-checks' sentinel job as the required status check in repository settings, instead of having to enumerate each individual job. While here, modernize the workflow: - Update actions/checkout from @master to @v4 - Use dtolnay/rust-toolchain instead of manual rustup where possible - Add concurrency settings to cancel in-progress runs on the same PR - Add explicit permissions (contents: read, write override for docs) - Add timeout-minutes to all jobs - Add fail-fast: false to the test matrix Assisted-by: OpenCode (Claude claude-opus-4-6)
Assisted-by: OpenCode (Claude claude-opus-4-6)
Collaborator
Author
|
@alexcrichton once this lands can you configure a Github branch protection rule to gate merges on:
Also while we're here other good flags to set if they're not (I can't see):
|
Owner
|
Thanks! I've checked all the boxes except for requiring a reviewer approval since I don't feel like that's quite ready yet in this repo, but the CI gates I would hope would be sufficient for now. I've also checked a box saying that PRs are required to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically IMO a key best practice is to configure github repositories to:
But the problem with "required checks" is one gets into a "Catch-22" quickly when refactoring CI jobs when one wants to rename a test or equivalent. In this pattern there's a
required-jobsjob that itself depends on configuration of the CI flow.This is what we do in https://github.com/bootc-dev/ repos.