Load environment variables as a resolver#480
Merged
alecthomas merged 1 commit intoalecthomas:masterfrom Feb 9, 2025
Merged
Conversation
alecthomas
reviewed
Dec 17, 2024
Contributor
Author
|
Just in case you pass by. I made some adjustments regarding your comments |
Contributor
Author
|
Bumping just in case |
alecthomas
approved these changes
Feb 8, 2025
Owner
alecthomas
left a comment
There was a problem hiding this comment.
I see your comment calls out applying to args, which I don't love special casing here to be honest, but in lieu of a better API, I definitely prefer this to hard wiring environment application.
Thanks!
Contributor
Author
|
it needed a rebase and minor fixes for the linter, can you approve once more? Results of the CI here: https://github.com/IxDay/kong/actions/runs/13225890198 |
Owner
|
This is awesome, thanks @IxDay :) |
Owner
|
Tagged v1.8.0 |
alecthomas
added a commit
that referenced
this pull request
Feb 13, 2025
Owner
Contributor
Author
|
I will take a look |
IxDay
added a commit
to IxDay/kong
that referenced
this pull request
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft as a discussion starting point. I need to add comments, and maybe simplify code a bit.
Closes: #477