Drop automatic message prefix from command errors#384
Merged
Conversation
Owner
|
Ah I remember what the intent of this was now - it was to put the command name in the error message. So eg. if you had |
Contributor
Author
|
Do you plan on cutting a release anytime soon? 😊 |
Contributor
Author
Ah okay! I think I’d personally still prefer for the error message to be unmodified, though, as that would give more control to the application in regards to how to error messages are displayed. |
livingsilver94
added a commit
to livingsilver94/backee
that referenced
this pull request
Nov 26, 2023
Kong v0.8.1 includes alecthomas/kong#384 which fixes the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #383.
With this PR, kong will pass through error messages from commands’
Run()methods as is, without wrapping them up or reformatting them.The
callMethodis obsolete now, its only purpose was the error wrapping. The callers can usecallFunctiondirectly.