Support string pointers for path mapper#360
Merged
alecthomas merged 1 commit intoMar 5, 2024
Merged
Conversation
alecthomas
approved these changes
Apr 22, 2023
Owner
|
Apologies for the (much) belated merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a use case where I would like to differentiate between an unset path and an empty string path (which expands to the current directory).
This PR updates the
pathMapperfunction to allow apathtype to be applied to a*stringto make this differentiation per the pointer behaviour described here: https://github.com/alecthomas/kong#pointers