fix: no text auto-sizing on webkit#1186
Merged
alecthomas merged 1 commit intoalecthomas:masterfrom Jan 3, 2026
jacqueminv:jacqueminv/1101-fix-ios-text-auto-sizing
Merged
fix: no text auto-sizing on webkit#1186alecthomas merged 1 commit intoalecthomas:masterfrom jacqueminv:jacqueminv/1101-fix-ios-text-auto-sizing
alecthomas merged 1 commit intoalecthomas:masterfrom
jacqueminv:jacqueminv/1101-fix-ios-text-auto-sizing
Conversation
1 task
Owner
|
Did you check this actually fixes it? |
Contributor
Author
|
I've run the following test from package chroma
import (
"testing"
"os"
"github.com/alecthomas/chroma/v2/quick"
)
func TestMain(t *testing.T) {
quick.Highlight(os.Stdout, `jq -c '[ .[] | {title: .media[0].title, date: first(.media[].creation_timestamp), pictures: .media | del(.[].creation_timestamp, .[].title, .[].media_metadata, .[].cross_post_source), location: first(.media[].media_metadata?.photo_metadata?.exif_data[0]?)} ]' posts_1.json > preprocess.json
echo "shorter line"`, "sh", "html", "monokai")
}I edited the html output to add a meta element to default the width to the device-width. ResultsHere are the results, I've executed the same test once without the bugfix from this PR and once with the bugfix. Without the bugfix from this PR
With the bugfix
|
That ensures that no line is displayed with a bigger font-size due to its length. see https://bugs.webkit.org/show_bug.cgi?id=304640 FIX 1101
Owner
|
Thanks! |
Contributor
Author
|
My pleasure! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That ensures that no line is displayed with a bigger font-size due to its length.
see https://bugs.webkit.org/show_bug.cgi?id=304640
Fixes #1101