Skip to content

Remove InterfaceIsType checkstyle module#417

Merged
wendigo merged 1 commit intoairlift:masterfrom
Randgalt:jordanz/remove-InterfaceIsType
Aug 8, 2024
Merged

Remove InterfaceIsType checkstyle module#417
wendigo merged 1 commit intoairlift:masterfrom
Randgalt:jordanz/remove-InterfaceIsType

Conversation

@Randgalt
Copy link
Copy Markdown
Contributor

This check prevents a modern Java idiom (and likely future idioms). E.g.

public sealed interface Choice
{
    record GoodChoice(...)
        implements Choice
    {
    }

    record BadChoice(...)
        implements Choice
    {
    }
}

The previous purpose of InterfaceIsType is arguably out of date anyway. It's better to use an interface for utility containers, etc.

This check prevents a modern Java idiom (and likely future idioms).
E.g.

```
public sealed interface Choice
{
    record GoodChoice(...)
        implements Choice
    {
    }

    record BadChoice(...)
        implements Choice
    {
    }
}
```

The previous purpose of `InterfaceIsType` is arguably out of date
anyway. It's better to use an interface for utility containers, etc.
@wendigo wendigo added the improvement Improvement to the existing code label Aug 5, 2024
@wendigo
Copy link
Copy Markdown
Contributor

wendigo commented Aug 7, 2024

@electrum WDYT? I'm in favor of merging it

@wendigo
Copy link
Copy Markdown
Contributor

wendigo commented Aug 8, 2024

Let's give it a shot.

@wendigo wendigo merged commit 4cc35f1 into airlift:master Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement to the existing code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants