Skip to content

Add benchmark for parsing the query string#1494

Merged
bdraco merged 4 commits intomasterfrom
bench_uncached_query_parse
Apr 5, 2025
Merged

Add benchmark for parsing the query string#1494
bdraco merged 4 commits intomasterfrom
bench_uncached_query_parse

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Apr 5, 2025

All the benchmarks we had were using the cache so we did not
have a good idea what the performance was here.

bdraco added 2 commits April 5, 2025 11:34
All the benchmarks we had were using the cache so we did not
have a good idea what the performance was here.
@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Apr 5, 2025
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 5, 2025

CodSpeed Performance Report

Merging #1494 will not alter performance

Comparing bench_uncached_query_parse (188a604) with master (f73f47e)

Summary

✅ 99 untouched benchmarks
🆕 2 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 test_parse_query_uncached[long] N/A 29.8 ms N/A
🆕 test_parse_query_uncached[short] N/A 2.6 ms N/A

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.92%. Comparing base (f73f47e) to head (188a604).
Report is 47 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1494   +/-   ##
=======================================
  Coverage   98.91%   98.92%           
=======================================
  Files          32       32           
  Lines        6012     6022   +10     
  Branches      358      359    +1     
=======================================
+ Hits         5947     5957   +10     
  Misses         62       62           
  Partials        3        3           
Flag Coverage Δ
CI-GHA 98.92% <100.00%> (+<0.01%) ⬆️
MyPy 98.05% <90.00%> (-0.02%) ⬇️
OS-Linux 98.85% <100.00%> (+<0.01%) ⬆️
OS-Windows 98.89% <100.00%> (+<0.01%) ⬆️
OS-macOS 98.62% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 98.60% <100.00%> (+<0.01%) ⬆️
Py-3.10.16 98.81% <100.00%> (+<0.01%) ⬆️
Py-3.11.11 98.81% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 98.60% <100.00%> (+<0.01%) ⬆️
Py-3.12.9 98.81% <100.00%> (+<0.01%) ⬆️
Py-3.13.2 98.81% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 98.56% <100.00%> (+<0.01%) ⬆️
Py-3.9.21 98.77% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 98.76% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.19 98.78% <100.00%> (+<0.01%) ⬆️
VM-macos-latest 98.62% <100.00%> (+<0.01%) ⬆️
VM-ubuntu-latest 98.85% <100.00%> (+<0.01%) ⬆️
VM-windows-latest 98.89% <100.00%> (+<0.01%) ⬆️
pytest 98.85% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bdraco bdraco marked this pull request as ready for review April 5, 2025 22:02
@bdraco bdraco merged commit 8fad627 into master Apr 5, 2025
48 of 50 checks passed
@bdraco bdraco deleted the bench_uncached_query_parse branch April 5, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:skip This PR does not need to include a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant