Merged
Conversation
_query_var is almost never called with subclassed values and all the issubclass calls add up with large query strings
bdraco
commented
Sep 8, 2024
bdraco
commented
Sep 8, 2024
…ed' into query_var_fast_path_non_subclassed
bdraco
commented
Sep 8, 2024
bdraco
commented
Sep 8, 2024
bdraco
commented
Sep 8, 2024
bdraco
commented
Sep 8, 2024
str objects
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1131 +/- ##
==========================================
+ Coverage 95.12% 95.15% +0.03%
==========================================
Files 30 30
Lines 4638 4647 +9
Branches 410 411 +1
==========================================
+ Hits 4412 4422 +10
+ Misses 200 199 -1
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bdraco
commented
Sep 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
_query_varis almost never called with subclassed values, and almost everything isstr. All theissubclasscalls add up with large query stringsAre there changes in behavior for the user?
No