Conversation
Optional[str] with Union[str, None]
Merged
Member
Author
|
Not sure what kind of changelog message this should get. Also near midnight here so I'll have to pick this up tomorrow. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1095 +/- ##
=======================================
Coverage 95.02% 95.02%
=======================================
Files 30 30
Lines 4459 4459
Branches 392 392
=======================================
Hits 4237 4237
Misses 196 196
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
I'd say “contrib” since it's improving the readability for contributors w/o any influence on how the type checkers would perceive this. |
webknjaz
reviewed
Sep 5, 2024
Optional[str] with Union[str, None]Optional with Union
webknjaz
approved these changes
Sep 6, 2024
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <webknjaz@redhat.com>
bdraco
commented
Sep 6, 2024
bdraco
added a commit
that referenced
this pull request
Sep 6, 2024
bdraco
added a commit
that referenced
this pull request
Sep 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Replace all
OptionalwithUnionWe have both in this project:
Optional[int]onportandUnion[int, None]onexplict_portis not so great. This is a short lived change sincepyupgradeis going to change them all totype | Noneonce we remove support for older python.Are there changes in behavior for the user?
no
Related issue number
#1084 (comment)
#1112 (comment)