Add typing to URL by bdraco · Pull Request #1084 · aio-libs/yarl

bdraco · 2024-09-02T21:01:44Z

What do these changes do?

Add typing to URL

Are there changes in behavior for the user?

no runtime changes


-    def with_query(self, *args, **kwargs):
+    @overload
+    def with_query(self, query: _Query) -> "URL": ...


+    def with_query(self, query: _Query) -> "URL": ...
+
+    @overload
+    def with_query(self, **kwargs: _QueryVariable) -> "URL": ...



-    def update_query(self, *args, **kwargs):
+    @overload
+    def update_query(self, query: _Query) -> "URL": ...


+    def update_query(self, query: _Query) -> "URL": ...
+
+    @overload
+    def update_query(self, **kwargs: _QueryVariable) -> "URL": ...


Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <webknjaz@redhat.com>

codecov · 2024-09-02T21:25:55Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.88%. Comparing base (d4e7601) to head (24768b8).
Report is 318 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1084      +/-   ##
==========================================
+ Coverage   93.06%   94.88%   +1.82%     
==========================================
  Files          31       30       -1     
  Lines        4424     4358      -66     
  Branches      370      382      +12     
==========================================
+ Hits         4117     4135      +18     
+ Misses        281      197      -84     
  Partials       26       26

Flag	Coverage Δ
CI-GHA	`94.83% <100.00%> (+1.82%)`	⬆️
MyPy	`38.91% <97.50%> (+11.94%)`	⬆️
OS-Linux	`99.34% <99.12%> (+<0.01%)`	⬆️
OS-Windows	`99.44% <99.12%> (+<0.01%)`	⬆️
OS-macOS	`99.02% <99.12%> (+<0.01%)`	⬆️
Py-3.10.11	`98.90% <98.24%> (-0.03%)`	⬇️
Py-3.10.14	`99.16% <98.24%> (-0.03%)`	⬇️
Py-3.11.9	`99.16% <98.24%> (-0.03%)`	⬇️
Py-3.12.5	`99.16% <98.24%> (-0.03%)`	⬇️
Py-3.13.0-rc.1	`99.16% <98.24%> (-0.03%)`	⬇️
Py-3.8.10	`98.85% <98.24%> (-0.03%)`	⬇️
Py-3.8.18	`99.11% <98.24%> (-0.03%)`	⬇️
Py-3.9.13	`98.85% <98.24%> (-0.03%)`	⬇️
Py-3.9.19	`99.11% <98.24%> (-0.03%)`	⬇️
Py-pypy7.3.11	`99.16% <98.24%> (-0.03%)`	⬇️
Py-pypy7.3.16	`99.19% <98.24%> (-0.03%)`	⬇️
VM-macos-latest	`99.02% <99.12%> (+<0.01%)`	⬆️
VM-ubuntu-latest	`99.34% <99.12%> (+<0.01%)`	⬆️
VM-windows-latest	`99.44% <99.12%> (+<0.01%)`	⬆️
pytest	`99.34% <99.12%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <webknjaz@redhat.com>

bdraco · 2024-09-03T05:51:08Z

path shows 100% diff hit on codecov but is reporting at 99.13% here...

https://app.codecov.io/gh/aio-libs/yarl/pull/1084?flags%5B0%5D=pytest&dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=checks&utm_campaign=pr%20comments&utm_term=aio-libs

webknjaz · 2024-09-03T12:00:14Z

path shows 100% diff hit on codecov but is reporting at 99.13% here...

Yeah, I suppose this was due to the proportion being different because the overall number of lines changed. I'm not seeing 99.13% there, though. Perhaps, it processed more reports after your comment.
For me, it shows 94.94% for the entire pytest flag and 99.88% for tests/ flagged with pytest and 98.15% for yarl/+pytest.

I suppose, it's okay to raise the codecov/project/lib expectation to 98.1% (leaving that 0.05% margin for future line count changes, until we can go for 100%).

Co-authored-by: Sam Bull <git@sambull.org>

bdraco · 2024-09-03T19:40:56Z

I'm going to do a RC0 release so I can run this in the CI of a few projects since typing changes are always hard to predict the impact

sergeniushpe · 2024-09-05T00:00:31Z

Hello, I think this change broke python 3.8 support:

../lib/python3.8/site-packages/yarl/_url.py:606: in URL
    def query(self) -> MultiDictProxy[str]:
E   TypeError: 'type' object is not subscriptable

If I downgrade to release 1.9.7 it works again.

You might want to update python requirements to indicate python>=3.9 is required

bdraco · 2024-09-05T00:06:47Z

Hello, I think this change broke python 3.8 support:
../lib/python3.8/site-packages/yarl/_url.py:606: in URL
    def query(self) -> MultiDictProxy[str]:
E   TypeError: 'type' object is not subscriptable
If I downgrade to release 1.9.7 it works again.

You might want to update python requirements to indicate python>=3.9 is required

Would you please open an issue report, I will fix it shortly

bdraco · 2024-09-05T00:08:47Z

Please include the multi dict version you are using in the issue

Dreamsorcerer · 2024-09-05T12:38:50Z

Please include the multi dict version you are using in the issue

As far as I can see, multidict has supported that syntax for ~6 years...
But, maybe we should increase the minimum version of multidict that yarl supports.

bdraco · 2024-09-05T13:12:54Z

I had to take the python 3.8 install back to multidict 4 to get it to fail. There might be a newer version that fails though as I stopped trying them once I confirmed the issue. Also even with 4 it didn’t fail on python 3.9 so I suspect the issue will go away on its own soon when we drop 3.8

Add typing to URL

9fdff60

github-advanced-security AI found potential problems Sep 2, 2024

View reviewed changes

bdraco added 2 commits September 2, 2024 11:06

changelog

8576fb0

py3.8

086a550

psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 2, 2024

Merge branch 'master' into typing

0fb8bad

webknjaz reviewed Sep 2, 2024

View reviewed changes

Comment thread CHANGES/1084.contrib.rst Outdated

Update CHANGES/1084.contrib.rst

10b65f3

Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <webknjaz@redhat.com>

webknjaz reviewed Sep 2, 2024

View reviewed changes

Comment thread CHANGES/1084.contrib.rst

bdraco added 2 commits September 2, 2024 11:14

feature as well

39c5596

Merge remote-tracking branch 'origin/typing' into typing

394d1ba

webknjaz reviewed Sep 2, 2024

View reviewed changes

Comment thread yarl/_url.py

bdraco added 2 commits September 2, 2024 11:30

copy exclude from aiohttp

857a9cd

Merge branch 'master' into typing

20ae93d

webknjaz reviewed Sep 2, 2024

View reviewed changes

Comment thread .coveragerc Outdated

webknjaz reviewed Sep 2, 2024

View reviewed changes

Comment thread .coveragerc Outdated

webknjaz reviewed Sep 2, 2024

View reviewed changes

Comment thread .coveragerc

bdraco added 4 commits September 2, 2024 11:41

comments, preen

5e9996d

Merge remote-tracking branch 'origin/master' into typing

0aa1802

Merge remote-tracking branch 'origin/master' into typing

40c71a0

Merge remote-tracking branch 'origin/typing' into typing

f5d5097

This was referenced Sep 2, 2024

🧪 Integrate covdefaults into coverage.py #1085

Merged

Problematic -> NoReturn exclusion asottile/covdefaults#152

Closed

webknjaz reviewed Sep 2, 2024

View reviewed changes

Comment thread .coveragerc Outdated

webknjaz reviewed Sep 3, 2024

View reviewed changes

Comment thread .coveragerc Outdated

webknjaz and others added 4 commits September 3, 2024 02:48

Merge branch 'master' into typing

3f1eb2b

Merge branch 'master' into typing

46633ba

Update .coveragerc

041ea65

Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <webknjaz@redhat.com>

drop pyi

cc17104

bdraco commented Sep 3, 2024

View reviewed changes

Comment thread yarl/_helpers_c.pyi

bdraco commented Sep 3, 2024

View reviewed changes

Comment thread .coveragerc Outdated

bdraco commented Sep 3, 2024

View reviewed changes

Comment thread .coveragerc Outdated

Update .coveragerc

db3750a

bdraco marked this pull request as ready for review September 3, 2024 05:54

webknjaz reviewed Sep 3, 2024

View reviewed changes

Comment thread yarl/_helpers_c.pyi

webknjaz reviewed Sep 3, 2024

View reviewed changes

Comment thread yarl/_url.py

Dreamsorcerer reviewed Sep 3, 2024

View reviewed changes

Comment thread yarl/_url.py Outdated

Dreamsorcerer reviewed Sep 3, 2024

View reviewed changes

Comment thread yarl/_url.py Outdated

Dreamsorcerer reviewed Sep 3, 2024

View reviewed changes

Comment thread yarl/_url.py Outdated

bdraco and others added 8 commits September 3, 2024 07:08

keep helpers_c

0af0733

Update yarl/_url.py

521ba15

Co-authored-by: Sam Bull <git@sambull.org>

Merge branch 'master' into typing

5d1b7a2

type dunder compares to object

b0e4e1c

Update yarl/_url.py

c6d37d9

Co-authored-by: Sam Bull <git@sambull.org>

Iterator

2aef0e7

remove hint

915ab95

temp lower

24768b8

bdraco merged commit e70f9d4 into master Sep 3, 2024

bdraco deleted the typing branch September 3, 2024 19:40

bdraco mentioned this pull request Sep 4, 2024

Replace all Optional with Union #1095

Merged

bdraco mentioned this pull request Sep 5, 2024

Hello, I think this change broke python 3.8 support: #1105

Closed

Uh oh!

Conversation

bdraco commented Sep 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What do these changes do?

Are there changes in behavior for the user?

Uh oh!

Check notice

Check notice

Check notice

Check notice

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Sep 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bdraco commented Sep 3, 2024

Uh oh!

webknjaz commented Sep 3, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bdraco commented Sep 3, 2024

Uh oh!

sergeniushpe commented Sep 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bdraco commented Sep 5, 2024

Uh oh!

bdraco commented Sep 5, 2024

Uh oh!

Dreamsorcerer commented Sep 5, 2024

Uh oh!

bdraco commented Sep 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bdraco commented Sep 2, 2024 •

edited

Loading

codecov bot commented Sep 2, 2024 •

edited

Loading

sergeniushpe commented Sep 5, 2024 •

edited

Loading