Skip to content

Optimize multidict extending#1101

Merged
asvetlov merged 24 commits intomasterfrom
optimize-extend
Mar 25, 2025
Merged

Optimize multidict extending#1101
asvetlov merged 24 commits intomasterfrom
optimize-extend

Conversation

@asvetlov
Copy link
Copy Markdown
Member

@asvetlov asvetlov commented Mar 24, 2025

No description provided.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Mar 24, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #1101 will improve performances by ×3.2

Comparing optimize-extend (47a0148) with master (20515ba)

Summary

⚡ 29 improvements
✅ 113 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ test_cimultidict_add_istr[c-extension-module] 2.8 ms 2.5 ms +14.32%
⚡ test_cimultidict_delitem_istr[c-extension-module] 115.6 µs 84.7 µs +36.46%
⚡ test_cimultidict_extend_istr[c-extension-module] 7.8 ms 2.4 ms ×3.2
⚡ test_cimultidict_extend_istr_with_kwargs[c-extension-module] 15.2 ms 6.3 ms ×2.4
⚡ test_cimultidict_pop_istr[c-extension-module] 110.7 µs 82.7 µs +33.94%
⚡ test_cimultidict_update_istr[c-extension-module] 153.5 µs 126.3 µs +21.56%
⚡ test_cimultidict_update_istr_with_kwargs[c-extension-module] 341.6 µs 291.4 µs +17.22%
⚡ test_copy_from_existing_cimultidict[c-extension-module] 28.4 µs 18 µs +57.27%
⚡ test_create_cimultidict_with_dict_istr[c-extension-module] 72.3 µs 41.2 µs +75.4%
⚡ test_create_cimultidict_with_items_istr_with_kwargs[c-extension-module] 140.4 µs 106.4 µs +31.94%
⚡ test_create_multidict_with_dict[case-insensitive-c-extension-module] 98 µs 66.1 µs +48.23%
⚡ test_create_multidict_with_dict[case-sensitive-c-extension-module] 64.5 µs 35 µs +84.27%
⚡ test_create_multidict_with_items_with_kwargs[case-insensitive-c-extension-module] 161 µs 126.1 µs +27.7%
⚡ test_create_multidict_with_items_with_kwargs[case-sensitive-c-extension-module] 98.3 µs 66.9 µs +47%
⚡ test_multidict_add_str[case-sensitive-c-extension-module] 2.1 ms 1.8 ms +18.79%
⚡ test_multidict_delitem_str[case-insensitive-c-extension-module] 165.3 µs 106.5 µs +55.18%
⚡ test_multidict_delitem_str[case-sensitive-c-extension-module] 104.8 µs 76.9 µs +36.39%
⚡ test_multidict_extend_str[case-insensitive-c-extension-module] 15.8 ms 8.5 ms +86.55%
⚡ test_multidict_extend_str[case-sensitive-c-extension-module] 7.6 ms 3 ms ×2.5
⚡ test_multidict_extend_str_with_kwargs[case-insensitive-c-extension-module] 24 ms 13.6 ms +76.36%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 24, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.86%. Comparing base (20515ba) to head (47a0148).
Report is 64 commits behind head on master.

Files with missing lines Patch % Lines
multidict/_multidict_py.py 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1101   +/-   ##
=======================================
  Coverage   92.86%   92.86%           
=======================================
  Files          44       44           
  Lines        5088     5088           
  Branches      385      385           
=======================================
  Hits         4725     4725           
  Misses         95       95           
  Partials      268      268
Flag Coverage Δ
CI-GHA 92.86% <80.00%> (ø)
MyPy 86.57% <80.00%> (ø)
pytest 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@psf-chronographer psf-chronographer Bot added the bot:chronographer:provided There is a change note present in this PR label Mar 25, 2025
@asvetlov asvetlov marked this pull request as ready for review March 25, 2025 16:22
@asvetlov asvetlov requested a review from webknjaz as a code owner March 25, 2025 16:22
@asvetlov asvetlov merged commit 6097b60 into master Mar 25, 2025
46 of 47 checks passed
@asvetlov asvetlov deleted the optimize-extend branch March 25, 2025 16:24
@bdraco bdraco mentioned this pull request Apr 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

Assignees

No one assigned

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@asvetlov