Skip to content

Fix __contains__ with unexpected types#1045

Merged
Dreamsorcerer merged 8 commits intomasterfrom
Dreamsorcerer-patch-1
Feb 18, 2025
Merged

Fix __contains__ with unexpected types#1045
Dreamsorcerer merged 8 commits intomasterfrom
Dreamsorcerer-patch-1

Conversation

@Dreamsorcerer
Copy link
Copy Markdown
Member

Found this while adding inline type annotations for mypy.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Feb 16, 2025

CodSpeed Performance Report

Merging #1045 will degrade performances by 17.92%

Comparing Dreamsorcerer-patch-1 (0045914) with master (25618eb)

Summary

❌ 1 regressions
✅ 37 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_cimultidict_extend_istr 108.5 µs 132.2 µs -17.92%

@psf-chronographer psf-chronographer Bot added the bot:chronographer:provided There is a change note present in this PR label Feb 16, 2025
Comment thread CHANGES/1045.bugfix.rst Outdated
Comment thread CHANGES/1045.bugfix.rst Outdated
Comment thread tests/test_multidict.py
Comment thread CHANGES/1045.bugfix.rst Outdated
Copy link
Copy Markdown
Member

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <webknjaz@redhat.com>
@Dreamsorcerer Dreamsorcerer merged commit b4d5c55 into master Feb 18, 2025
@Dreamsorcerer Dreamsorcerer deleted the Dreamsorcerer-patch-1 branch February 18, 2025 01:23
@Dreamsorcerer Dreamsorcerer mentioned this pull request Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants