Skip to content

Speed up starting compression#9169

Merged
bdraco merged 5 commits intomasterfrom
start_compression_enum
Sep 22, 2024
Merged

Speed up starting compression#9169
bdraco merged 5 commits intomasterfrom
start_compression_enum

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Sep 17, 2024 •
edited
Loading

What do these changes do?

Enumerating a enum and accessing all the .value is not performant. Switching to a pre-built dict is significantly faster

Are there changes in behavior for the user?

no

Is it a substantial burden for the maintainers to support this?

no

related issue #2779

before
start_compression_before

after
start_compression_after

@bdraco
Speed up starting compression
c85f1e4 
Enumerating a enum and accessing all the .value is
not performant. Switching to a dict is significantly
faster
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.33%. Comparing base (756fae8) to head (c9f95f4).
Report is 1061 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #9169   +/-   ##
=======================================
  Coverage   98.33%   98.33%           
=======================================
  Files         107      107           
  Lines       34644    34645    +1     
  Branches     4115     4116    +1     
=======================================
+ Hits        34066    34067    +1     
  Misses        408      408           
  Partials      170      170
Flag Coverage Δ
CI-GHA 98.22% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.89% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.31% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.57% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.67% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 97.60% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 97.49% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.56% <100.00%> (+<0.01%) ⬆️
Py-3.12.6 97.95% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.55% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 97.49% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 97.11% <100.00%> (+<0.01%) ⬆️
VM-macos 97.57% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.89% <100.00%> (+<0.01%) ⬆️
VM-windows 96.31% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 18, 2024
@bdraco bdraco marked this pull request as ready for review September 18, 2024 05:51
Dreamsorcerer
Dreamsorcerer reviewed Sep 18, 2024
View reviewed changes
Comment thread aiohttp/web_response.py
@bdraco bdraco mentioned this pull request Sep 18, 2024
Merged
@bdraco bdraco merged commit fce4f8e into master Sep 22, 2024
@bdraco bdraco deleted the start_compression_enum branch September 22, 2024 14:23
@patchback
Copy link
Copy Markdown
Contributor

patchback bot commented Sep 22, 2024 •
edited
Loading

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/fce4f8ec97ee8ef20d1c9c64321218234036a17e/pr-9169

Backported as #9222

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 22, 2024
@bdraco @patchback
Speed up starting compression (#9169)
3d53d43 
(cherry picked from commit fce4f8e)
@patchback patchback bot mentioned this pull request Sep 22, 2024
Merged
@patchback
Copy link
Copy Markdown
Contributor

patchback bot commented Sep 22, 2024 •
edited
Loading

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/fce4f8ec97ee8ef20d1c9c64321218234036a17e/pr-9169

Backported as #9223

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 22, 2024
@bdraco @patchback
Speed up starting compression (#9169)
657f709 
(cherry picked from commit fce4f8e)
@patchback patchback bot mentioned this pull request Sep 22, 2024
Merged
bdraco added a commit that referenced this pull request Sep 22, 2024
@patchback @bdraco
[PR #9169/fce4f8ec backport][3.10] Speed up starting compression (#9222)
985c00f 
Co-authored-by: J. Nick Koston <nick@koston.org>
bdraco added a commit that referenced this pull request Sep 22, 2024
@patchback @bdraco
[PR #9169/fce4f8ec backport][3.11] Speed up starting compression (#9223)
1401f6e 
Co-authored-by: J. Nick Koston <nick@koston.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dreamsorcerer Dreamsorcerer Dreamsorcerer left review comments

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees

No one assigned

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bdraco @Dreamsorcerer