Fix cancellations being swallowed#9030
Conversation
for more information, see https://pre-commit.ci
| except asyncio.CancelledError: | ||
| return | ||
| await writer.drain() | ||
| await self._continue |
Check notice
Code scanning / CodeQL
Statement has no effect
| t.cancel() | ||
| # Cancellation should not be suppressed. | ||
| with pytest.raises(asyncio.CancelledError): | ||
| await t |
Check notice
Code scanning / CodeQL
Statement has no effect
|
|
||
| t.cancel() | ||
| with pytest.raises(asyncio.CancelledError): | ||
| await t |
Check notice
Code scanning / CodeQL
Statement has no effect
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #9030 +/- ##
==========================================
- Coverage 98.42% 98.41% -0.01%
==========================================
Files 107 107
Lines 34714 34765 +51
Branches 4116 4123 +7
==========================================
+ Hits 34167 34214 +47
Misses 380 380
- Partials 167 171 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
| t.cancel() | ||
| # Cancellation should not be suppressed | ||
| with pytest.raises(asyncio.CancelledError): | ||
| await t |
Check notice
Code scanning / CodeQL
Statement has no effect
Backport to 3.10: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 1a77ad9 on top of patchback/backports/3.10/1a77ad933f07ab0e7ba0c16f7ca8f02fa8ab044e/pr-9030 Backporting merged PR #9030 into master
🤖 @patchback |
Backport to 3.11: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 1a77ad9 on top of patchback/backports/3.11/1a77ad933f07ab0e7ba0c16f7ca8f02fa8ab044e/pr-9030 Backporting merged PR #9030 into master
🤖 @patchback |
Co-authored-by: J. Nick Koston <nick@koston.org> (cherry picked from commit 1a77ad9)
Co-authored-by: J. Nick Koston <nick@koston.org> (cherry picked from commit 1a77ad9)
Fixes #8174.
Fixes #8175.