Update the release process and setup the process to specify tags #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4832d26 to
0fba8e2
Compare
Collaborator
Author
|
Hi @jackton1, could you please review the PR? |
kevinmatthes
reviewed
Dec 1, 2022
| - name: Setup the release version and overwrite the existing major version tag | ||
| run: | | ||
| major_version=$(echo $GITHUB_REF_NAME | cut -d. -f1) | ||
| git config --local user.email "github-actions[bot]@users.noreply.github.com" |
There was a problem hiding this comment.
By the way: there is also a GitHub Action to take care for exactly this setup of the GitHub Actions bot. You can call it as follows:
- name: user
uses: fregante/setup-git-user@v1.1.0It needs to have access to the file contents, i.e. it requires a preceding actions/checkout call and at least permissions.contents: read in the permissions section. Also large organisations like Adobe and Ansible make use of this Action; see https://github.com/fregante/setup-git-user/network/dependents (page 2, as of this writing) for reference.
Maybe this could help to enhance the maintainability of this workflow.
Collaborator
Author
There was a problem hiding this comment.
@kevinmatthes Thanks for the hint. I'll check that.
Closed
marcoantonio-af
approved these changes
Dec 26, 2023
jackton1
suggested changes
Mar 9, 2024
jackton1
suggested changes
Mar 9, 2024
0fba8e2 to
a2a6943
Compare
jackton1
approved these changes
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change is related to the following issue.