Merged
Conversation
…dicator of mismatch failure
GhadimiR
commented
Mar 5, 2025
| /** | ||
| * Returns true if the digest of the downloaded artifact does not match the expected hash | ||
| */ | ||
| digestMismatch?: boolean |
Contributor
Author
There was a problem hiding this comment.
This is kinda dual-use in that it returns false if the digests match OR if a digest wasn't supplied (i.e. we're not doing the comparison), imo this is fine because the consumer of this interface knows if a digest was supplied and so it has all the information needed, but if there's a more elegant way to do this I'd love to hear about it.
JoannaaKL
reviewed
Mar 6, 2025
JoannaaKL
approved these changes
Mar 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Artifacts REST API and Twirp services now return a digest field, giving a SHA256 digest of whatever was uploaded to the service.
This change (combined with the implementation on the
download-artifactpackage, will allow end users to use this to perform a comparison of this digest against the downloaded artifact to validate the integrity of what was downloaded.The intent here is that the
download-artifactpackage can then use the digests from the list method to supply them to download only if the comparison is desired. That package can also decide on whether to end the workflow or warn.