Merged
Conversation
konradpabjan
approved these changes
Jan 18, 2024
vmjoseph
approved these changes
Jan 18, 2024
campersau
reviewed
Jan 18, 2024
|
|
||
| return deleteArtifactInternal(artifactName) | ||
| } catch (error) { | ||
| warning( |
Contributor
There was a problem hiding this comment.
Since there is no await for deleteArtifactPublic / deleteArtifactInternal is this warning actually printed when something goes wrong asynchronously? To me it looks this only catches errors which are thrown synchronously.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having official client methods to delete artifacts will make some use cases much simpler.
For instance, this could allow the ability to overwrite an artifact eventually in actions/upload-artifact.
e.g.
Where overwrite would delete an artifact first, allowing for the upload of another.
I'll update the documentation in a separate PR.
Closes: #380
Partially supports: actions/upload-artifact#471