Add function to return proxy agent dispatcher for compatibility with latest octokit packages#1547
Merged
Add function to return proxy agent dispatcher for compatibility with latest octokit packages#1547
octokit packages#1547Conversation
pje
reviewed
Oct 5, 2023
pje
reviewed
Oct 5, 2023
pje
approved these changes
Oct 5, 2023
Contributor
pje
left a comment
There was a problem hiding this comment.
I was unfamiliar with undici, so I had to do some research :)
Overall I'm happy to ✅ — my only question is really on the necessity of bumping the major version of the package, but I'll defer to your judgment there!
Jason3S
reviewed
Oct 16, 2023
| "dependencies": { | ||
| "tunnel": "^0.0.6" | ||
| "tunnel": "^0.0.6", | ||
| "undici": "^5.25.4" |
There was a problem hiding this comment.
When updating today, I noticed that size of my action bloated by 15k lines because undici was included as a dependency.
There was a problem hiding this comment.
the same for me. I've raised a ticket for the issue #1621
mgrybyk
reviewed
Jan 10, 2024
| import * as http from 'http' | ||
| import * as httpm from '../lib/' | ||
| import * as pm from '../lib/proxy' | ||
| import {ProxyAgent} from 'undici' |
There was a problem hiding this comment.
this line causes the "lightweight" client size to increase 3x times by 1Mb of code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add function to return proxy agent dispatcher for compatibility with latest
octokitpackages.Octokit docs