Bump test dependencies to resolve System.Net.Http vulnerability, update workflows and README#692
Merged
HarithaVattikuti merged 4 commits intoactions:mainfrom Jan 13, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses a security vulnerability (CVE-2018-8292) in the transitive dependency System.Net.Http 4.3.0 by upgrading test dependencies to their latest versions, and resolves documentation issues related to Windows CMD shell formatting of global.json files. The changes include comprehensive version updates throughout test files and workflows to use .NET 8.0, 9.0, and 10.0.
Key Changes:
- Upgraded test dependencies: Microsoft.NET.Test.Sdk to 18.0.1, MSTest.TestAdapter and MSTest.TestFramework to 4.0.2, successfully eliminating the System.Net.Http 4.3.0 vulnerability
- Updated all test files and workflows from .NET 6.0/7.0 references to 9.0/10.0 for current relevance
- Consolidated workflow test jobs to reduce duplication while maintaining comprehensive coverage across all supported operating systems
- Added documentation note about Windows shell requirements for
global.jsongeneration
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
__tests__/e2e-test-csproj/test.csproj |
Updated test dependencies to latest secure versions (Microsoft.NET.Test.Sdk 18.0.1, MSTest packages 4.0.2) |
__tests__/e2e-test-csproj/packages.lock.json |
Regenerated lock file with updated dependencies targeting net10.0, removing vulnerable System.Net.Http 4.3.0 |
__tests__/e2e-test-csproj/Test.cs |
Fixed assertion parameter order to follow MSTest conventions (expected, actual) |
__tests__/e2e-test-csproj/AssemblyInfo.cs |
Added DoNotParallelize attribute for sequential test execution |
__tests__/verify-dotnet.ps1 |
Added support for .NET 10.0 framework mapping |
__tests__/setup-dotnet.test.ts |
Updated test version references from 6.0 to 10.0 |
__tests__/installer.test.ts |
Updated test version references from 3.1/6.0 to 10.0 for consistency |
README.md |
Updated actions/checkout from v5 to v6, version examples to 8.0/9.0/10.0, and added Windows shell guidance |
.github/workflows/test-dotnet.yml |
Updated matrix to test .NET 8.0, 9.0, 10.0 instead of 6.0, 7.0, 8.0, 9.0 |
.github/workflows/e2e-tests.yml |
Consolidated test jobs and updated versions to 9.0/10.0, expanding OS matrix to include ubuntu-latest and macos-latest |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aparnajyothi-y
previously approved these changes
Dec 29, 2025
mahabaleshwars
approved these changes
Dec 30, 2025
aparnajyothi-y
approved these changes
Dec 30, 2025
HarithaVattikuti
approved these changes
Jan 13, 2026
This was referenced Jan 21, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR includes:
Bumps test dependencies in
__tests__/e2e-test-csproj/test.csprojto their latest available versions:Microsoft.NET.Test.Sdkfrom 15.5.0-preview-20170810-02 to 18.0.1.MSTest.TestAdapterfrom 1.1.18 to 4.0.2.MSTest.TestFrameworkfrom 1.1.18 to 4.0.2.Updates workflow configuration for improved clarity and removes references to older .NET versions.
Updates the README:
pwshorbashwhen generating a temporaryglobal.jsonon Windows to avoid formatting issues.Related issues:
#676
#683
Check list: