Build: use .mjs extensions for build-module files#74348
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 3.08 MB ℹ️ View Unchanged
|
Member
Author
|
@manzoorwanijk @aduth @youknowriad This is now ready as a followup to #73822. It should fix the issues that Jetpack encounters when trying to use the I had to give up on Instead, the published files in After some additional fixes here and there, renaming a few files (mostly stylelint) from One major package I found that uses this convention is stylelint. No |
manzoorwanijk
approved these changes
Jan 7, 2026
Member
manzoorwanijk
left a comment
There was a problem hiding this comment.
This makes more sense, and I agree that the explicit extension regardless of the type field in the package.json makes it more reliable, robust, and portable.
This was referenced Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to fix the CJS build issues described in #73822 (comment). The plan is to:
type: modulefrompackage.jsonfiles, because that enables strict Node.js compat in esbuild (Double wrapping when converting esm to cjs evanw/esbuild#2623) which makes it practically impossible to usedefaultexports while producing CJS versions of packages.type: moduleuse the.mjsextension for all ESM files. The idea is that we don't use.jsextensions, for whichtype: moduleprovides the default format, but we always specify the module format explicitly, with the.cjsor.mjsextension.Let's see what CI checks think about this.