Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
12 tasks
|
Size Change: -509 B (-0.02%) Total Size: 2.58 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 527fb30. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/20315055994
|
ntsekouras
reviewed
Dec 18, 2025
Contributor
ntsekouras
left a comment
There was a problem hiding this comment.
Cool to see this go, thanks! This looks good, but I'm wondering if there are a few removals/changes to happen.
- There are some cases where
__nextHasNoMarginBottomis still in some types. For exampleSearchControlPropsuseInputControlPropsand the__nextHasNoMarginBottom. Should it be updated withPick< BaseControlProps, '__nextHasNoMarginBottom'like some other changes here? - What about the remaining
__nextHasNoMarginBottom: _, // Prevent passing to internal componentcases? Do we still need them?
Member
Author
|
Good questions! Both are intentional in this case:
These were left as is because I noticed they aren't actually based on
These are for preventing warnings from being logged in dev tools, if a consumer hasn't cleaned up the prop and it gets passed down to some internal element that doesn't accept the prop (part of the "don't punish early adopters" agreement in #55401). Some of the internal components won't actually log warnings if they're based on Emotion, because invalid attributes are filtered automatically there, but the guard is kept anyway to avoid issues when the component is eventually moved off of Emotion. |
ntsekouras
approved these changes
Dec 18, 2025
Contributor
|
Thanks for the detailed explanation! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #73848
Remove the deprecated
__nextHasNoMarginBottomprop fromBaseControl, making the margin-free styles the permanent default.Why?
The soft deprecation was introduced in WP 6.7 and scheduled to be removed in WP 7.0. This removes the prop, completing the deprecation cycle.
How?
__nextHasNoMarginBottomprop fromBaseControland its types and docs.BaseControl) that wasn't caught up to this point.BaseControlprops, where appropriate.Testing Instructions
Smoke test the affected components in Storybook and the app.