Skip to content

DataViews: Remove extra wrapper for GridItem#73665

Merged
ntsekouras merged 1 commit intotrunkfrom
dataviews-grid-remove-extra-wrapper
Dec 2, 2025
Merged

DataViews: Remove extra wrapper for GridItem#73665
ntsekouras merged 1 commit intotrunkfrom
dataviews-grid-remove-extra-wrapper

Conversation

@ntsekouras
Copy link
Copy Markdown
Contributor

What?

Follow up of: #72997

@tellthemachines' comment:

Just curious, is there any reason why we had to nest GridItem inside a div here?

So this PR removes the extra div wrapper and makes the GridItem open for extension to be used properly from the Ariakit Composite.Item.

Testing Instructions

  1. Grid keyboard navigation should work exactly as before.

@ntsekouras ntsekouras self-assigned this Dec 1, 2025
@ntsekouras ntsekouras added [Type] Code Quality Issues or PRs that relate to code quality [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond labels Dec 1, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 1, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ntsekouras ntsekouras force-pushed the dataviews-grid-remove-extra-wrapper branch from ec7fffe to d9a3118 Compare December 1, 2025 08:18
Copy link
Copy Markdown
Contributor

@tellthemachines tellthemachines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up on this! Code LGTM and works as expected in testing ✅

@ntsekouras ntsekouras merged commit 84c5cfa into trunk Dec 2, 2025
35 checks passed
@ntsekouras ntsekouras deleted the dataviews-grid-remove-extra-wrapper branch December 2, 2025 06:18
@github-actions github-actions Bot added this to the Gutenberg 22.3 milestone Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants